Support formaction and formmethod on <button>

[jacob-ebey]

Bug: The these two forms should POST to the same URL but do not.

<form>
  <button formaction="/action" formmethod="POST">Submit</button>
</form>
<form hx-boost="true">
  <button formaction="/action" formmethod="POST">Submit Boosted</button>
</form>

Fix: take into account formaction and formmethod of the submitter.

I'm not familiar with the HTMX codebase but issueAjaxRequest seemed like a reasonable place to handle this. event.submitter is relatively new as well, so you might want a more backwards compatible implementation, but this shows the gist of the issue and the fix.

Instead of using event.submitter, I have opted to use the tracked button click on the internal data. This should work on all browser targets supported by HTMX.

[jacob-ebey]

Addresses #623

[alexpetros]

Closing this on account of not following the contribution guidelines, re: IE 11 support.

I do appreciate you calling that out though, as I wouldn't have thought to look for it otherwise.

[jacob-ebey]

Closing this on account of not following the contribution guidelines, re: IE 11 support.

I do appreciate you calling that out though, as I wouldn't have thought to look for it otherwise.

You plan on addressing this? If not, please re open this and I'll update it for ie11

[alexpetros]

Sure! If you want to update for IE11 compatibility I'm happy to re-open it.

[jacob-ebey]

I'm super jetlaged at the moment but will try to get to it before the weekend is up.

[jacob-ebey]

@alexpetros Updated to use existing internals to support IE11.

[alexpetros]

Yup, this looks great, thank you! Seems like a very straightforward thing to support.

[xhaggi]

On May 24, I created the following PR #1451 that already contained this fix in ce9ccff.

Too bad things have to be addressed twice as PRs sit around for months.

[alexpetros]

This PR is a little easier to merge than the linked change, unfortunately. The linked change would also support attributes changing after the process step, which is definitely good, but also a larger surface area for regressions, which is why we haven't gotten to it yet.

[adoublef]

following as I just discovered I was having issues figuring how to use the formaction with hx-boost for a simple counter example (using v1.9.5)

[alexpetros]

You should be good to go as soon as the 1.9.6 release is cut (very soon)!

[jacob-ebey]

Cheers 🥂