Sortable example fixes #1868
Merged
Sortable example fixes #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this one ready for review? |
yes it is @alexpetros |
alexpetros
added
ready for review
|
Can you add some inline comments in the code explaining what you explain here in the description? It's a good (and I think necessary) fix, but it does take away somewhat from the simplicity of the example so it would help to offset that with a little explanation. |
|
@alexpetros Sure! How does it look? |
alexpetros
approved these changes
Oct 9, 2023
sjc5
pushed a commit
to sjc5/htmx
that referenced
this pull request
Oct 31, 2023
* add missing quotation mark * make `.htmx-indicator` unsortable * change cursors to indicate grabbable items * bug fix: bug: when an item is dragged fast enough before the previous request was completed, dropping after request completion resulted in the addition of an extra item to the list. fix: disable sortable on End event, and re-enable it on htmx:afterSwap. * add a few inline comments + better naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Fix bug where, when an item is dragged fast enough before a previous request is completed, dropping it after the request's completion resulted in the addition of an extra item to the list. This is fixed by disabling the sortable on its
endevent, and re-enabling it on itshtmx:afterSwapevent.Before:
before.mp4
After:
after.mp4
Disable draggability of the
.htmx-indicator("Updating...") element.Before:
before.mp4
After:
after.mp4
Other changes:
.htmx-indicatortodefaultrather thantext, since it's not supposed to be selectable especially while hidden.