chore: add missing options to HtmxConfig type #2026
Conversation
|
Please rebase + retarget against dev, otherwise looks good |
|
Done. |
| * The type of binary data being received over the WebSocket connection | ||
| * @default blob | ||
| */ | ||
| wsBinaryType?: Blob; |
There was a problem hiding this comment.
I think the type is wrong here, wsBinaryType should be a string as per the Websocket.binaryType doc as it's a parameter passed to the latter
Its default value is "blob" but not of type blob if I'm not mistaken.
It can also take only 2 values which might be relevant to specify them here to act as an enum?
Value
A string
"blob"
Use Blob objects for binary data. This is the default value.
"arraybuffer"
Use ArrayBuffer objects for binary data.
There was a problem hiding this comment.
Ahhh, I think you're right. I can make another PR to amend.
I also realised after that methodsThatUseUrlParams?: string[]; is probably not strict enough and it should be ('get' | 'post' | ...etc )[]
There was a problem hiding this comment.
Just cut a new one and reference this one, no problem
Description
When playing around with View Transitions, I noticed that the
globalViewTransitionsproperty, as well as some other options, were missing from theHtmxConfigtype. This PR aligns theHtmkConfigwith the options listed on htmx.org.Corresponding issue:
Testing
None
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded