Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Tiny fixes for Hotwire page. #2322

Merged
merged 3 commits into from Feb 21, 2024

Conversation

gnat
Copy link
Contributor

@gnat gnat commented Feb 15, 2024

Before / After

  • hx-on wrapping fix.
  • Linkify github issue.
  • Brought hx-on link down to 1 line in Stimulus section.

image

@gnat gnat changed the title Solve wrapping issues for small content area. Docs: Solve wrapping issues for small content area. Feb 15, 2024
@gnat gnat changed the title Docs: Solve wrapping issues for small content area. Docs: Tiny fixes for Hotwire page. Feb 15, 2024
@gnat
Copy link
Contributor Author

gnat commented Feb 19, 2024

@Atmos4 What's the problem? This is a revision of a previous commit.

Anyways, done. The narrow content area can be challenging-- a line break on hx- is very jarring.

@Atmos4
Copy link

Atmos4 commented Feb 20, 2024

No problem here 🙂
Same comment with the await, the rest LGTM!

Edit: now I noticed my reaction, oops it was not intended 😅 removed!

@alexpetros alexpetros merged commit e8f243c into bigskysoftware:master Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants