Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Required module not found #1

Closed
raduchiriac opened this issue Dec 15, 2017 · 4 comments
Closed

[Question] Required module not found #1

raduchiriac opened this issue Dec 15, 2017 · 4 comments

Comments

@raduchiriac
Copy link

raduchiriac commented Dec 15, 2017

EDIT: I am using yarn workspaces and lerna
Probably not a real issue but I am getting flow-geojson. Required module not found when using this.

import type {
  Point2D,
  MultiPoint2D,
  LineString2D,
  MultiLineString2D,
  Polygon2D,
  MultiPolygon2D,
} from 'flow-geojson';

Following this did not help:
facebook/flow#2092 (comment)

Because I now get
Type annotations require valid Flow declaration flowtype/no-types-missing-file-annotation

@bigslycat
Copy link
Owner

Thanks for report. I review it in next 4 hours.

@bigslycat
Copy link
Owner

@raduchiriac thanks for report, but it just works. =)

2017-12-16 00-01-08

Please read about this Flow ESLint plugin rule — no-types-missing-file-annotation. Make sure you have the valid Flow file declaration.

Please tell me about result.

@raduchiriac
Copy link
Author

raduchiriac commented Dec 18, 2017

It needed more clarifications from my side as I am actually using yarn workspaces with lerna. (I will edit the original question as well).

I first tried to yarn add inside the subfolder where I needed this package, and since the package will be installed in the root, I am guessing the symlinks are not properly created and I got flow-geojson. Required module not found. Not sure how to debug this case.

The only workaround I found is doing yarn add -W flow-geojson in the root (which is not ideal, I only have jest, eslint, babel in the root) and removing node_modules from my .flowconfig ignore.

Let's leave it closed as it's a very specific case, will come back with more details

@bigslycat
Copy link
Owner

If you are using an npm package that supports flow, you should not ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants