Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several config issues #421

Merged
merged 5 commits into from Oct 9, 2020
Merged

Fix several config issues #421

merged 5 commits into from Oct 9, 2020

Conversation

thisiskeithb
Copy link
Contributor

@thisiskeithb thisiskeithb commented Oct 8, 2020

Description

  • Use correct TMC current values for Crealtiy/Ender-3 steppers. X/Y/Z should be 580 and E0 should be 650.
  • Updated chopping timings to 24v
  • Fix PID/Temperature settings
  • Fix SKR Mini E3 V1.0 TMC Slave Addresses
  • Increase EXTRUDE_MAXLENGTH to 600 (as the Ender-3 is a bowden printer)

See the Ender-3 configs in the Marlin Configurations repo.

Benefits

Stepper motors won't overheat, TMCs will operate correctly, temperatures will be more stable, etc.

Related Issues

#420, #414

Use correct TMC current values for Crealtiy/Ender-3 steppers.
The Ender-3 is a 24v printer.
@thisiskeithb thisiskeithb changed the title Reduce Default TMC Current Values & Fix Chopper Timings Fix several config issues Oct 8, 2020
@thisiskeithb
Copy link
Contributor Author

There are still more config updates that can be done, but these are the big ones. Perhaps it'd be a better idea to pull the configs from the Marlin Configurations repo instead?

@brew99
Copy link

brew99 commented Oct 8, 2020

as u/thisiskeithb mentioned above, it would probably be in the best interest if BTT just used the configs from Marlin source, as they are continually updated and proven by many users.

@bigtreetech bigtreetech merged commit 9c13742 into bigtreetech:master Oct 9, 2020
@thisiskeithb thisiskeithb deleted the pr/fix_tmc_currents branch October 9, 2020 00:58
@Gamester17
Copy link
Contributor

Gamester17 commented Oct 9, 2020

@bigtreetech Another argument for removing config from this repo and instead simply pointing to upstream example is that it contains different configurations for each printer that the BIGTREETECH SKR Mini E3 boards are designed for, which includes Creality's CR-10 and CR-10S series that among other things has different voltage and bed sizes. Please see these examples:

https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/CR-10
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/CR-10S
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/Ender-3
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/Ender-3%20Pro
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/Ender-5

Should be noted though that example config for some supported printers is however still missing and would surely be welcomed:
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/CR-10%20Mini
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/CR-10%20S4/CrealityV1
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/CR-10%20S5/CrealityV1
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/Ender-5%20Pro
https://github.com/MarlinFirmware/Configurations/tree/import-2.0.x/config/examples/Creality/Ender-5_Plus

prkknn pushed a commit to prkknn/BIGTREETECH-SKR-mini-E3 that referenced this pull request Jul 8, 2022
* Reduce default TMC Current Values

Use correct TMC current values for Crealtiy/Ender-3 steppers.

* Fix chopper timing

The Ender-3 is a 24v printer.

* Fix Temperature/PID settings

* Fix SKR Mini E3 V1.0 TMC Slave Addresses

* Increase EXTRUDE_MAXLENGTH to 600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants