Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model preview for cura plug-in unit #844

Merged
merged 1 commit into from
Jul 21, 2020
Merged

model preview for cura plug-in unit #844

merged 1 commit into from
Jul 21, 2020

Conversation

Msq001
Copy link
Contributor

@Msq001 Msq001 commented Jul 15, 2020

Requirements

Description

Benefits

Related Issues

@rebel1
Copy link
Contributor

rebel1 commented Jul 15, 2020

Great !

Copy link
Contributor

@rebel1 rebel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works Great. Tested on Bigtreetech 3.5 and an MKS Clone on my Sidewinder

@juavinas
Copy link

Works Great. Tested on Bigtreetech 3.5 and an MKS Clone on my Sidewinder

Where did you get *.27 firmware?

from: https://github.com/bigtreetech/Bigtree3DPlugin
Update touch screen firmware after this Pull request, The first release to include this feature is Vx.x.27

@BsCmOD
Copy link
Contributor

BsCmOD commented Jul 18, 2020

Works Great. Tested on Bigtreetech 3.5 and an MKS Clone on my Sidewinder

Where did you get *.27 firmware?

from: https://github.com/bigtreetech/Bigtree3DPlugin
Update touch screen firmware after this Pull request, The first release to include this feature is Vx.x.27

Infact it's the same question I've done to my self! I've tested this funtion before read firmware update note to x.x.27 version but I can't find it nowhere

@NicoletoAerials
Copy link
Contributor

It works great!!!!!!! Compiled from the master and tested on TFT 35 v3 and SKR mini E3 v1.2 on an ender 3

@BsCmOD
Copy link
Contributor

BsCmOD commented Jul 19, 2020

It works great!!!!!!! Compiled from the master and tested on TFT 35 v3 and SKR mini E3 v1.2 on an ender 3

Have you used the actual firmware which is in tft repesotari of btt? So, with x.x.26 the thumbnail works?

@NicoletoAerials
Copy link
Contributor

It works great!!!!!!! Compiled from the master and tested on TFT 35 v3 and SKR mini E3 v1.2 on an ender 3

Have you used the actual firmware which is in tft repesotari of btt? So, with x.x.26 the thumbnail works?

Yes I used the oficial master x.x.26 firmware. As far as I know is the one that has the newest modifications and fixes.

Anyway, both, the master or the bug fix x.x.26.1 should work just fine. The changes needed are compatible with both firmware versions.

Copy link
Contributor

@NicoletoAerials NicoletoAerials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Works great. Master firmware X.X.26 ,TFT35 v3, SKR mini e3 v1.2, ender 3

@bigtreetech
Copy link
Owner

@BsCmOD the Vx.x.27 is the first RELEASE version support this feature, the firmware will support this feature as long as this PR is merged. This week I will test and fix bugs in the firmware and release Vx.x.27 at the weekend

@ghost
Copy link

ghost commented Jul 20, 2020

so where exactly is Vx.x.27 located, i cant find it and it doesn't work for me with .26 firmware for me

@Tygrys-1
Copy link
Contributor

so where exactly is Vx.x.27 located, i cant find it and it doesn't work for me with .26 firmware for me

None yet. You may just use this PR commit and build firmware by youself.

@ghost
Copy link

ghost commented Jul 20, 2020

so where exactly is Vx.x.27 located, i cant find it and it doesn't work for me with .26 firmware for me

None yet. You may just use this PR commit and build firmware by youself.

oh, i dont know how to do the building firmware, too complex for me

@bigtreetech bigtreetech merged commit 9739f9e into bigtreetech:master Jul 21, 2020
@Msq001 Msq001 deleted the bugfix-preview-model branch July 21, 2020 05:36
@GregSKR
Copy link
Contributor

GregSKR commented Jul 21, 2020

Nice work.
I can see that compilation shows some problems:

/TFT/src/User/API/UI/ui_draw.c
lines 59 and 88
unused variable 'mybr' [-Wunused-variable]

/TFT/src/User/my_misc.c
lines 172 and 191
array subscript has type 'char' [-Wchar-subscripts]

After removing lines 59 and 88 in ui_draw.c,
and replacing
for (char i = 0; i < 2; i++)
with
for (uint8_t i = 0; i < 2; i++)
in my_misc.c (lines 172 and 191)
problems as gone!..

@BsCmOD
Copy link
Contributor

BsCmOD commented Jul 31, 2020

@BsCmOD the Vx.x.27 is the first RELEASE version support this feature, the firmware will support this feature as long as this PR is merged. This week I will test and fix bugs in the firmware and release Vx.x.27 at the weekend

@bigtreetech Have you got some news?

@redgod
Copy link

redgod commented Aug 3, 2020

ya esta la version x.27?

@redgod
Copy link

redgod commented Aug 5, 2020

no funciona con firmware x.26.x tft24 1.1

Manu512 pushed a commit to Manu512/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 3, 2020
Co-authored-by: Msq001 <Msq001@gmail.com>
@SkifBor
Copy link

SkifBor commented Jan 27, 2021

The plugin works great. Thank you! Can I change the color of the model?

1 similar comment
@SkifBor
Copy link

SkifBor commented Jan 27, 2021

The plugin works great. Thank you! Can I change the color of the model?

@BsCmOD
Copy link
Contributor

BsCmOD commented Jan 27, 2021

The plugin works great. Thank you! Can I change the color of the model?

Yes, if you change material color in Cura it will change also the preview color on tft

@SkifBor
Copy link

SkifBor commented Jan 27, 2021

Thank you very much!

@aqasna
Copy link

aqasna commented Aug 7, 2021

Works Great. Tested on Bigtreetech 3.5 and an MKS Clone on my Sidewinder

Where did you get *.27 firmware?
from: https://github.com/bigtreetech/Bigtree3DPlugin
Update touch screen firmware after this Pull request, The first release to include this feature is Vx.x.27

Infact it's the same question I've done to my self! I've tested this funtion before read firmware update note to x.x.27 version but I can't find it nowhere

https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/releases

copy to sd card..insert on screen slot (not board)

  1. config.ini
    2.bin file (depend ur model)
  2. on the theme folder got pack..only copy pack for ur lcd size

jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Co-authored-by: Msq001 <Msq001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet