Refactor sidebar logic into reusable component

[gromdimon]

Issue: #1380

[gromdimon]

It seems, that there's no template tags which can be removed after refactoring. However, I found that projectroles_tags.get_role_import_action is not used anywhere. Is it some kind of an artifact or or it's used somewhere in sodar-server/varfish or I missed something?

btw. this template_tag was not used in _project_sidebar.html

[mikkonie]

It seems, that there's no template tags which can be removed after refactoring. However, I found that projectroles_tags.get_role_import_action is not used anywhere. Is it some kind of an artifact or or it's used somewhere in sodar-server/varfish or I missed something?

Nice find. This seems to be an old template tag related to remote project sync which was refactored away, but I guess we forgot to remove the tag. It shouldn't be used anywhere else either, as it's in the projectroles_tags module, not the projectroles_common_tags one. Feel free to remove. It can be done as part of this branch even if not directly related.

[mikkonie]

The implementation is working correctly, good work. Here are some comments. There is one major thing I missed in my spec, I will write a separate comment about that and also update the spec.

[mikkonie]

Ok, so: I completely overlooked _project_menu_btn.html in my spec. It is basically a responsive replacement for the sidebar, containing the exact same links but rendered as a dropdown.

Needless to say, this should also be refactored to use the new helper class instead of having the logic within its template. So here's what should be done:

1. Refactor _project_menu_btn.html to get links from the helper and render them as is done currently
2. Remove unused template tags

[mikkonie]

This is proceeding nicely, I had some more feedback.

[mikkonie]

Good work! I had just a couple very minor comments, after these I'm happy to merge.