add cram support (#1908, #1914)

bihealth · Feb 28, 2024 · 1e206ca · 1e206ca
1 parent 33534cb
commit 1e206ca
Show file tree

Hide file tree

Showing 13 changed files with 453 additions and 63 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -19,6 +19,8 @@ Added
     - UI tests for project details card (#1902)
 - **Samplesheets**
     - ``IrodsDataRequest`` timeline event extra data (#1912)
+    - CRAM file support in study apps (#1908)
+    - ``check_igv_file_suffix()`` helper in ``studyapps.utils`` (#1908)
 - **Taskflowbackend**
     - Django settings in siteinfo (#1901)
     - ``BatchSetAccessTask`` in iRODS tasks (#1905)
@@ -64,6 +66,7 @@ Fixed
     - ``IrodsDataRequest._validate_action()`` failing with ``delete`` action (#1858)
     - Protocol ref editable for new row if disabled in column config (#1875)
     - Sheet template creation failure with slash characters in title/ID fields (#1896)
+    - ``get_pedigree_file_path()`` used in cancer study app tests (#1914)
 - **Taskflowbackend**
     - Hardcoded iRODS path length in ``landing_zone_move`` (#1888)
     - Uncaught exceptions in ``SetAccessTask`` (#1906)

diff --git a/config/settings/base.py b/config/settings/base.py
@@ -807,11 +807,11 @@ def set_logging(level=None):
 # Remote sample sheet sync interval in minutes
 SHEETS_SYNC_INTERVAL = env.int('SHEETS_SYNC_INTERVAL', 5)
 
-# BAM file name suffixes to omit from study shortcuts and IGV session generation
+# BAM/CRAM file name suffixes to omit from study shortcuts and IGV sessions
 SHEETS_IGV_OMIT_BAM = env.list(
     'SHEETS_IGV_OMIT_BAM', default=['dragen_evidence.bam']
 )
-# VCF file name suffixes to omit from study shortcuts and IGV session generation
+# VCF file name suffixes to omit from study shortcuts and IGV sessions
 SHEETS_IGV_OMIT_VCF = env.list(
     'SHEETS_IGV_OMIT_VCF', default=['cnv.vcf.gz', 'ploidy.vcf.gz', 'sv.vcf.gz']
 )

diff --git a/docs_manual/source/sodar_release_notes.rst b/docs_manual/source/sodar_release_notes.rst
@@ -13,6 +13,7 @@ v0.14.2 (WIP)
 
 Release for minor updates, maintenance and bug fixes.
 
+- Add CRAM file support for cancer/germline study links and IGV sessions
 - Add assay plugin shortcut collection creation in landing zones
 - Add iRODS data request details in timeline events
 - Add landing zone statistics in siteinfo
@@ -25,6 +26,17 @@ Release for minor updates, maintenance and bug fixes.
 - Minor updates and bug fixes
 - Upgrade to SODAR Core v0.13.4
 
+Migration Guide
+---------------
+
+CRAM File Support
+    This release adds support for CRAM files. They are linked in studies and IGV
+    sessions similar to BAM files. If your project contains CRAM files uploaded
+    prior to this release, you will have to run :guilabel:`Update Sheet Cache`
+    in the Sample Sheets app to enable the files in study links and generated
+    IGV sessions. Alternatively, an administrator can run the ``synccache``
+    management command to update all projects or a specific project.
+
 
 v0.14.1 (2023-12-12)
 ====================

diff --git a/samplesheets/plugins.py b/samplesheets/plugins.py
@@ -213,12 +213,12 @@ class ProjectAppPlugin(
         'igv_omit_bam': {
             'scope': SODAR_CONSTANTS['APP_SETTING_SCOPE_PROJECT'],
             'type': 'STRING',
-            'label': 'BAM files to omit from IGV sessions',
+            'label': 'BAM and CRAM files to omit from IGV sessions',
             'default': '',
             'placeholder': ', '.join(settings.SHEETS_IGV_OMIT_BAM),
-            'description': 'Comma separated list of BAM file suffixes to omit '
-            'from generated IGV sessions. Overrides site-wide setting, affects '
-            'cancer and germline projects.',
+            'description': 'Comma separated list of BAM and CRAM file suffixes '
+            'to omit from generated IGV sessions. Overrides site-wide setting, '
+            'affects cancer and germline projects.',
             'user_modifiable': True,
         },
         'igv_omit_vcf': {

diff --git a/samplesheets/studyapps/cancer/plugins.py b/samplesheets/studyapps/cancer/plugins.py
@@ -85,8 +85,8 @@ def get_shortcut_column(self, study, study_tables):
                 'files': {
                     'type': 'modal',
                     'icon': 'mdi:folder-open-outline',
-                    'title': 'View links to BAM, VCF and IGV session files '
-                    'for the case',
+                    'title': 'View links to BAM/CRAM, VCF and IGV session '
+                    'files for the case',
                 },
             },
             'data': [],
@@ -172,7 +172,7 @@ def get_shortcut_links(self, study, study_tables, **kwargs):
             'title': 'Case-Wise Links for {}'.format(case_id),
             'data': {
                 'session': {'title': 'IGV Session File', 'files': []},
-                'bam': {'title': 'BAM Files', 'files': []},
+                'bam': {'title': 'BAM/CRAM Files', 'files': []},
                 'vcf': {'title': 'VCF Files', 'files': []},
             },
         }
@@ -190,7 +190,7 @@ def _add_lib_path(library_name, file_type):
                         'extra_links': [
                             {
                                 'label': 'Add {} file to IGV'.format(
-                                    file_type.upper()
+                                    'BAM/CRAM' if file_type == 'bam' else 'VCF'
                                 ),
                                 'icon': 'mdi:plus-thick',
                                 'url': get_igv_irods_url(path, merge=True),