Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SODAR Core v0.13.0 #1617

Closed
9 of 10 tasks
mikkonie opened this issue Mar 31, 2023 · 3 comments
Closed
9 of 10 tasks

Upgrade to SODAR Core v0.13.0 #1617

mikkonie opened this issue Mar 31, 2023 · 3 comments
Assignees
Labels
breaking Breaking change, to be implemented and documented with care environment Issues of dependencies, CI, deployment etc.
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Mar 31, 2023

The major SODAR Core upgrade v0.13.0 will be out soonish. SODAR v0.14 will be upgraded to run on it.

This needs to be carefully coordinated with Varfish and Kiosc, as SODAR Core v0.13 breaks a lot of things including remote sync backwards compatibility.

Tasks

  • Upgrade dependencies
  • Figure out for advanced search problem (see core changes)
  • Ensure permissions are correctly maintained for the extended role inheritance
  • Ensure iRODS access is correctly added/removed with role inheritance
  • Add iRODS inherited member sync in syncmodifyapi
  • Update samplesheets and landingzones modify API calls
  • Update perms tests to include new inherited roles
  • Fix test cleanup (see comments)
  • Fix up all other potentially breaking things
  • Reinstall versioneer
@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care environment Issues of dependencies, CI, deployment etc. labels Mar 31, 2023
@mikkonie mikkonie added this to the v0.14.0 milestone Mar 31, 2023
@mikkonie mikkonie self-assigned this Mar 31, 2023
mikkonie added a commit that referenced this issue May 2, 2023
mikkonie added a commit that referenced this issue May 2, 2023
mikkonie added a commit that referenced this issue May 5, 2023
mikkonie added a commit that referenced this issue May 5, 2023
mikkonie added a commit that referenced this issue May 10, 2023
mikkonie added a commit that referenced this issue May 15, 2023
mikkonie added a commit that referenced this issue May 15, 2023
mikkonie added a commit that referenced this issue May 25, 2023
mikkonie added a commit that referenced this issue May 30, 2023
@mikkonie
Copy link
Contributor Author

After the most recent upgade, one of the tests fails when running all tests. If run separately in just one class, these work. Something must be going wrong with tearDown() and iRODS somewhere.

======================================================================
FAIL: test_command_multiple (irodsadmin.tests.test_commands.TestIrodsOrphans)
Test command with multiple orphans
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mikkopen/code/sodar/irodsadmin/tests/test_commands.py", line 474, in test_command_multiple
    self.assertEqual(expected, out.getvalue())
AssertionError: 'e361ce40-c845-434c-ae7d-2f33fd62ca7b;Test[306 chars]es\n' != '021072ea-8418-4c3f-8ed4-8862e97a6142;<DEL[56856 chars]es\n'
Diff is 57211 characters long. Set self.maxDiff to None to see it.
----------------------------------------------------------------------

@mikkonie
Copy link
Contributor Author

mikkonie commented Jun 1, 2023

I can't reproduce the aforementioned issue locally or in CI. It appears it was caused by some earlier failed test which didn't properly clean up the test iRODS server. This should be somehow improved of course, but for the time being I can let this slide.

mikkonie added a commit that referenced this issue Jun 1, 2023
mikkonie added a commit that referenced this issue Jun 1, 2023
mikkonie added a commit that referenced this issue Jun 1, 2023
@mikkonie
Copy link
Contributor Author

mikkonie commented Jun 1, 2023

Done.

@mikkonie mikkonie closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, to be implemented and documented with care environment Issues of dependencies, CI, deployment etc.
Projects
None yet
Development

No branches or pull requests

1 participant