Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor iRODS delete request operations dropdown template #1751

Closed
mikkonie opened this issue Aug 11, 2023 · 1 comment
Closed

Refactor iRODS delete request operations dropdown template #1751

mikkonie opened this issue Aug 11, 2023 · 1 comment
Assignees
@mikkonie
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone
v0.14.0

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Aug 11, 2023 •
edited
Loading

There are some issues with this dropdown:

  • It contains ID values and parameters from the filesfolders app in SODAR Core for some reason
    • These are obviously not used here at all
  • The include file name is _list_buttons.html which makes no sense
    • There are many lists within the samplesheets app
  • ..but it is also, in fact, included as a separate template for no reason
    • There's no iteration and the parent template is not terribly complex
  • The IDs don't follow regular conventions

I will do this as a part of #1583 since the template must be altered heavily anyway.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: samplesheets Issue in the samplesheets app labels Aug 11, 2023
@mikkonie mikkonie added this to the v0.14.0 milestone Aug 11, 2023
@mikkonie mikkonie self-assigned this Aug 11, 2023
@mikkonie mikkonie changed the title Refactor iRODS delete request operations dropdown Refactor iRODS delete request operations dropdown template Aug 11, 2023
mikkonie added a commit that referenced this issue Aug 11, 2023
@mikkonie
update tour help (wip) (#1583), fix #1751
37f8627
@mikkonie
Copy link
Contributor Author

Fixed, to be merged as a part of #1583 and #1689.

mikkonie added a commit that referenced this issue Aug 11, 2023
@mikkonie
remove _list_buttons.html template (#1751)
e7fcd67
mikkonie added a commit that referenced this issue Aug 14, 2023
@mikkonie
update tour help (wip) (#1583), fix #1751
ba76dd6
mikkonie added a commit that referenced this issue Aug 14, 2023
@mikkonie
remove _list_buttons.html template (#1751)
85acf78
mikkonie added a commit that referenced this issue Aug 15, 2023
@mikkonie
update tour help (wip) (#1583), fix #1751
4f79352
mikkonie added a commit that referenced this issue Aug 15, 2023
@mikkonie
remove _list_buttons.html template (#1751)
16191f2
mikkonie added a commit that referenced this issue Aug 28, 2023
@mikkonie
update tour help (wip) (#1583), fix #1751
5ac18c1
mikkonie added a commit that referenced this issue Aug 28, 2023
@mikkonie
remove _list_buttons.html template (#1751)
29acb4a
mikkonie added a commit that referenced this issue Aug 28, 2023
@mikkonie
update docs, refactor templates (#1583, #1688, #1689, #1751)
97960a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
v0.14.0
Development

No branches or pull requests
1 participant
@mikkonie