Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issuing iRODS read-only tickets for assay collections #804

Closed
mikkonie opened this issue Feb 4, 2020 · 2 comments
Closed

Add issuing iRODS read-only tickets for assay collections #804

mikkonie opened this issue Feb 4, 2020 · 2 comments
Assignees
Labels
app: samplesheets Issue in the samplesheets app feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Feb 4, 2020

Discussed this with @holtgrewe and @dieter.beule.

Spec (As I've Understood It)

  • Enable issuing read-only-tickets to specific assay collections
    • not only limited to track hubs as is currently implemented
  • The collections will be accessed via the tickets using DavRODS, similar to how track hubs are right now

Questions/TBD

  • Should we allow this for any arbitrary collection within an assay?
    • ..or could there e.g. be some specific collection(s) eligible for this, similar to track hubs?
    • If specific, how do we mark them?
    • The ability to create publicly accessible tickets for any assay collection basically bypasses all project member access control when it comes to accessing iRODS data. This doesn't sound like a good idea to me.
  • Who should have the permission to create/revoke these tickets?
    • Owner/delegate only, or all contributors?
    • IMHO, if we decide to allow this for any collection within an assay, it definitely should be limited to project/delegate
  • Should we restrict access by host? iRODS tickets allow this
    • In case of Kiosc, is the requesting host the Kiosc server host or the client?
  • Do we also need a REST API endpoint for this, or is UI enough?

I'll talk to @january.weiner about this to find out what the exact use case is.

@mikkonie
Copy link
Contributor Author

One possibility to think of is also: are Davrods tickets the best way to handle this?

In case of e.g. Kiosc, we already have project access known to Kiosc which hosts the docker container, from which we request data?

Would it be possible to have some sort of view in Kiosc or SODAR which would check against the current user's project permissions (or maybe a token) and serve the file directly from iRODS?

Probably would be a lot work and maybe not even feasible, but just thinking aloud.

@mikkonie mikkonie self-assigned this Jun 15, 2022
@mikkonie mikkonie changed the title Samplesheets: Add issuing iRODS read-only tickets for assays Add issuing iRODS read-only tickets for assays Jun 15, 2022
@mikkonie mikkonie added the app: samplesheets Issue in the samplesheets app label Jun 15, 2022
@mikkonie mikkonie changed the title Add issuing iRODS read-only tickets for assays Add issuing iRODS read-only tickets for assay collections Jul 6, 2022
@mikkonie mikkonie modified the milestones: v0.13.0, v0.14.0 Dec 16, 2022
@mikkonie mikkonie removed the tbd Comments wanted, spec/schedule/prioritization to be decided, etc. label Jun 9, 2023
mikkonie added a commit that referenced this issue Jun 13, 2023
mikkonie added a commit that referenced this issue Jun 13, 2023
mikkonie added a commit that referenced this issue Jun 14, 2023
mikkonie added a commit that referenced this issue Jun 14, 2023
@mikkonie
Copy link
Contributor Author

Done. I'll add a separate ticket for REST API views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: samplesheets Issue in the samplesheets app feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant