Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call assay app update_row() already during rendering #956

Open
mikkonie opened this issue Oct 2, 2020 · 1 comment
Open

Call assay app update_row() already during rendering #956

mikkonie opened this issue Oct 2, 2020 · 1 comment
Assignees
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization) tbd Comments wanted, spec/schedule/prioritization to be decided, etc.

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Oct 2, 2020

This would speed up loading of the sample sheet view for large sheets, as we don't have to iterate (or even render) the tables multiple times.

Can't think of a reason not to do this, at least off the top of my head.

This information is only relevant for the UI, so this could be done together with #694. Will look into it for SODAR v0.10.

@mikkonie
Copy link
Contributor Author

Looking at this ticket 10 months later, it seems this would actually involve either moving the entire get_irods_content() function or parts of it to rendering. The only real advantage of this is not having to iterate over table rows twice and I'm not sure if it's really a huge benefit.

I'll look into this more closely when I next do more general refactoring of the rendering but for now, I'm moving this to the backlog.

@mikkonie mikkonie self-assigned this Jun 15, 2022
@mikkonie mikkonie changed the title Samplesheets: Call assay app update_row() already during rendering Call assay app update_row() already during rendering Jun 15, 2022
@mikkonie mikkonie added the app: samplesheets Issue in the samplesheets app label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization) tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Projects
None yet
Development

No branches or pull requests

1 participant