Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samplesheets: Make generating Vue.js app specific data optional in rendering.build_study_tables() #694

Closed
mikkonie opened this issue Oct 25, 2019 · 2 comments
Closed

Samplesheets: Make generating Vue.js app specific data optional in rendering.build_study_tables() #694

mikkonie opened this issue Oct 25, 2019 · 2 comments
Assignees
@mikkonie
Labels
internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone
SODAR v0.11.0

Comments

@mikkonie
Copy link
Contributor

Currently we always generate this data such as cell alignment, numbers-only-columns, maximum value length etc, even though they are only used in the Vue.js app rendering. Probably not a huge performance issue, but redundant nonetheless.
@mikkonie
Copy link
Contributor Author

mikkonie commented Oct 1, 2021

mentioned in commit bd0c3cf

@mikkonie
Copy link
Contributor Author

mikkonie commented Oct 1, 2021

Done.

@mikkonie mikkonie self-assigned this Jun 15, 2022
This was referenced Aug 30, 2021
Closed
Open
HaraldWilhelmi pushed a commit to dieterich-lab/sodar-server that referenced this issue Sep 22, 2023
@mikkonie
optimize and cleanup samplesheets.rendering (bihealth#694, bihealth#1262
bd0c3cf 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
SODAR v0.11.0
Development

No branches or pull requests
1 participant
@mikkonie