Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Report of Student Submission #6

Closed
soachishti opened this issue Aug 29, 2017 · 13 comments
Closed

Generate Report of Student Submission #6

soachishti opened this issue Aug 29, 2017 · 13 comments

Comments

@soachishti
Copy link
Collaborator

No description provided.

@recluze
Copy link
Collaborator

recluze commented Sep 1, 2017

This would be higher priority than #9 ...

@recluze
Copy link
Collaborator

recluze commented Sep 1, 2017

Please push to branch whenever you have something on reports so that I can take a look. I promise I won't mess with your branch =]

@soachishti
Copy link
Collaborator Author

Sure, I will keep the remote branch updated. =]

@soachishti
Copy link
Collaborator Author

Pull request added. #23

@recluze
Copy link
Collaborator

recluze commented Sep 3, 2017

Great work with the report. I really like the "Edit" button to fix any mistakes by the autograder.

Some changes:

  1. Should add the "username" column along with roll no.
  2. Add "Submission date". This would be for the latest ... just as the pass/fail fields.
  3. Make table sortable on all columns (client-side).
  4. For "percent", I forget: are we actually displaying "percent" or total points (given that we have assignment score in the meta data for the assignment. I think we should be displaying actual "score" instead of percentage.

BTW, did you check with multiple students/assignments to ensure we're not getting any mixups?

@recluze
Copy link
Collaborator

recluze commented Sep 3, 2017

(very low priority: syntax highlighting for the code shown in the popup in report.)

@soachishti
Copy link
Collaborator Author

soachishti commented Sep 3, 2017

#24

@recluze
Copy link
Collaborator

recluze commented Sep 4, 2017

Assignment report seems to have a bug:

def get_student_latest_submissions(self):
        # TODO: Try to acheive this by sub queries using Django ORM
        # Get students of this course
        students = Student.objects.filter(courses=self.course)
        submissions = []
        for student in students:
            submission = Submission.objects.filter(student=student).order_by("-publish_date").first()
            if submission:
                submissions.append(submission)

It's not checking for a particular assignment. We're getting back whatever happens to be the latest submission. So, if you submit an older assignment later, that shows up.

@recluze
Copy link
Collaborator

recluze commented Sep 4, 2017

The way we need to do this is to find the course associated with the assignment, then find all students that are enrolled and then get their score for this particular assignment. In case there is no record of submission by a student, we show a - in their row. This is so that we know exactly which students have submitted and not omit those that haven't made any submission.

@soachishti
Copy link
Collaborator Author

Such a silly mistake :) #27

@recluze
Copy link
Collaborator

recluze commented Sep 4, 2017

Nice work with the report. It seems very usable now.

Just get rid of the duplicate assignment object from here: https://github.com/BilalZaib/AutoGrader/blob/8ae7e29e9fbc94d2d8c10be1de887a9b8a2a72f2/AutoGrade/views.py#L334

And see if you can disable email verification on the other bug. We can then deploy this tomorrow inshaallah and see if the students can bring up some bugs.

Thanks again for all the good work (especially over the holidays).

@soachishti
Copy link
Collaborator Author

Fixed the duplicate in #31 and Email verification is fixed in #30 using Outlook SMTP.

@recluze
Copy link
Collaborator

recluze commented Sep 5, 2017

Let's close this.

@recluze recluze closed this as completed Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants