Mattermost #704
Comments
|
This needs an update, i'm trying to do it here, but no lucky... |
|
|
|
Current release 4.7.2 and i'm not seen your icons on this location: |
|
assets: |
|
ough, it's 5.0.0 RC |
|
I'm on version 5.0.0-rc1-13336. |
|
similar bug #646 |
|
downgrade to 4.7.2 |
|
I'm fixed Gitify manually, with a script that replace files. |
|
and #637 to |
|
I'm fixing Gitify like this... |
|
@acarasimon96 Timothy you know python, maybe you can help solve this error? For test you can use this app. Extract archives and found resources/app.asar file. |
|
I just successfully ran Hardcode Tray Git version on Mattermost desktop 5.0.0-rc1, but I'm not getting a It appears that the tray icons in
For comparison, here are the icons from Papirus that the script should've used to replace the above: I don't think this looks like an easy fix for me, but it's possible to get it done. This will take a couple days for me to find out the cause and implement a fix since I also have school, chores at home, and other interests to deal with. I apologize for any inconvenience that may arise out of my life situation. Also, thank you for the unexpected ping, @varlesh. I'm thrilled to be able to help you out with this issue! Edit: I forgot to upload the debug logfile, so here you go: 2021-09-21 19:36:04.log |
|
I'm temporarily using this solution to fix tray icons on my |
|
@acarasimon96 Thanks for your efforts... it's only your desire, I do not insist |
for 5.0.0 RC need use this config |
|
Oh, I didn't realize to do that first. Now I'm getting the same exact error @rauldipeas got. |
|
I was able to fix the crash, and it was a bit easier than I thought. It was caused by a directory that is literally called "offset" inside app.asar. I changed the code to where it makes sure that the value for "offset" is a string (that is, the real offset value of a file) before recalculating it. However, for some weird reason, I still couldn't get the script to replace the mention and unread icons. I would consider this issue solved once that new bug gets fixed and no other side effects come out of that. |
Some Electron apps, such as Mattermost Desktop 5.0.0 (bilelmoussaoui#704), contain a directory named "offset" in their app.asar files, which is treated in code as a dict of dicts representing files and subdirectories. Hardcode Tray expects a string for actual offset values before recalculating them. This fix adds a check to make sure that it only performs the said action on offset numbers.
|
@acarasimon96 glad to hear about success |
|
Other files not backuped |
It turns out that a few typos in this comment with the modified Here is the corrected mattermost.electron.json file{
"name": "Mattermost",
"app_path": [
"/opt/Mattermost/",
"/usr/lib/mattermost/"
],
"icons_path": [
"/opt/Mattermost/resources/",
"/usr/lib/mattermost/resources/"
],
"binary": "app.asar",
"script": "electron",
"icons": {
"tray-light": {
"original": "assets/linux/top_bar_light_16.png",
"theme": "mattermost-tray"
},
"tray-light-unread": {
"original": "assets/linux/top_bar_light_unread_16.png",
"theme": "mattermost-unread"
},
"tray-light-mention": {
"original": "assets/linux/top_bar_light_mention_16.png",
"theme": "mattermost-mention"
},
"tray-light@2x": {
"original": "assets/linux/top_bar_light_16@2x.png",
"theme": "mattermost-tray"
},
"tray-light@2x-unread": {
"original": "assets/linux/top_bar_light_unread_16@2x.png",
"theme": "mattermost-unread"
},
"tray-light@2x-mention": {
"original": "assets/linux/top_bar_light_mention_16@2x.png",
"theme": "mattermost-mention"
},
"tray-dark": {
"original": "assets/linux/top_bar_dark_16.png",
"theme": "mattermost-tray"
},
"tray-dark-unread": {
"original": "assets/linux/top_bar_dark_unread_16.png",
"theme": "mattermost-unread"
},
"tray-dark-mention": {
"original": "assets/linux/top_bar_dark_mention_16.png",
"theme": "mattermost-mention"
},
"tray-dark@2x": {
"original": "assets/linux/top_bar_dark_16@2x.png",
"theme": "mattermost-tray"
},
"tray-dark@2x-unread": {
"original": "assets/linux/top_bar_dark_unread_16@2x.png",
"theme": "mattermost-unread"
},
"tray-dark@2x-mention": {
"original": "assets/linux/top_bar_dark_mention_16@2x.png",
"theme": "mattermost-mention"
}
}
}
And below is the final result with the icons properly replaced P.S. @rauldipeas, please remember to submit a new PR containing the new JSON file. |
|
also i'm extract patched asar and selected files - it's Papirus files 100 % |
|
@acarasimon96 Congratulations, you are cool!!! 🥇 |
|
Sure, go ahead, but make sure you test the PR first on your system before merging. I'm glad I was able to help out. 😊 |
|
@acarasimon96 Big thx!!! I'm also test it with other problem apps Franz #637 & Gitify #646 and merged |
I'm doing this |
|
Thank you so much @acarasimon96 and @varlesh, this fix help-me so much! |
|
Franz & Gitify fixed too! |
|
I'm on Mattermost 5.0.4, and hardcode-tray doesn't detect it. Does it work for others? |
|
|
|
@rauldipeas Interesting... I do have It is detecting my apps just fine |
The text was updated successfully, but these errors were encountered: