Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote desktop persistence and session restore. #201

Merged

Conversation

Adamskye
Copy link
Contributor

Addresses issue #200.

Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm, unfortunately this is an API break so we can't land it in 0.8.2. It will have to wait until 0.9

src/desktop/remote_desktop.rs Outdated Show resolved Hide resolved
src/desktop/mod.rs Outdated Show resolved Hide resolved
src/desktop/mod.rs Outdated Show resolved Hide resolved
Adamskye and others added 4 commits March 20, 2024 22:36
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
@Adamskye
Copy link
Contributor Author

I should probably update the demos too. I'll do this tomorrow.

@bilelmoussaoui
Copy link
Owner

I should probably update the demos too. I'll do this tomorrow.

The demo targets stable ashpd, so we will have to land this PR first. Then you can open a new one for the demo that switches the ashpd dependency to use ashpd from git instead. The said PR won't be merged until we release 0.9 in the future.

@bilelmoussaoui bilelmoussaoui merged commit aad9ec1 into bilelmoussaoui:master Mar 21, 2024
6 checks passed
@bilelmoussaoui
Copy link
Owner

Thanks for your contribution

@Adamskye Adamskye deleted the remote_desktop_persistence branch March 21, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants