Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong cache-key used for caching #80

Closed
tytan652 opened this issue Apr 29, 2022 · 2 comments
Closed

Wrong cache-key used for caching #80

tytan652 opened this issue Apr 29, 2022 · 2 comments

Comments

@tytan652
Copy link
Contributor

tytan652 commented Apr 29, 2022 •
edited
Loading

While trying to switch to default cache-key in obsproject/obs-studio#5137.
We were trying remove the cache-key settings when this issue happen.

An unexpected issue has occurred:

Cache Size: ~1123 MB (1177260662 B)
/usr/bin/tar --use-compress-program zstd -d -xf /__w/_temp/a957e912-7502-4f61-a192-d3e489b47e8d/cache.tzst -P -C /__w/obs-studio/obs-studio
Cache restored successfully
Restored cache with key: -x86_64

https://github.com/bilelmoussaoui/flatpak-github-actions/blob/9b33ba80aec2fc2652e05f15f19929fa98182889/flatpak-builder/index.js#L209-L212

It seems that cacheKey even if empty does not fullfill the condition and generate a wrong cache key which ends up being -x86_64 in our situation.
@tytan652 tytan652 changed the title Wrong cache restored Wrong cache-key used for caching Apr 29, 2022
tytan652 added a commit to tytan652/obs-studio that referenced this issue Apr 30, 2022
@tytan652
CI: Use manifest hash as Flatpak cache key
91582d0 
flatpak/flatpak-github-actions#80
This issue is preventing the removal of the cache-key in the actions
inputs.
tytan652 added a commit to tytan652/obs-studio that referenced this issue Apr 30, 2022
@tytan652
CI: Use manifest hash as Flatpak cache key
d1a05bb 
flatpak/flatpak-github-actions#80
This issue is preventing the removal of the cache-key in the actions
inputs to use the default cache key.
RytoEX pushed a commit to obsproject/obs-studio that referenced this issue May 3, 2022
@tytan652 @RytoEX
CI: Use manifest hash as Flatpak cache key
bf60019 
flatpak/flatpak-github-actions#80
This issue is preventing the removal of the cache-key in the actions
inputs to use the default cache key.
davidmyersdev pushed a commit to davidmyersdev/obs-studio that referenced this issue May 15, 2022
@tytan652 @davidmyersdev
CI: Use manifest hash as Flatpak cache key
06dc4fc 
flatpak/flatpak-github-actions#80
This issue is preventing the removal of the cache-key in the actions
inputs to use the default cache key.
@andyholmes
Copy link
Contributor

I believe this one was fixed in #48, it just hasn't had a release since that was merged. I've been using .../flatpak-builder@master and it seems to work as expected.

@bilelmoussaoui
Copy link
Member

Closing as already fixed, I will try to do a new release in the upcoming weeks

DioEgizio added a commit to DioEgizio/PrismLauncher that referenced this issue Nov 19, 2022
@DioEgizio
fix(actions): fix cache on flatpak
c27ebde 
currently there's a [bug](flatpak/flatpak-github-actions#80) on the stable version of the flatpak action which causes the cache key to be wrong. this commit work arounds it

Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
@DioEgizio DioEgizio mentioned this issue Nov 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andyholmes @bilelmoussaoui @tytan652