This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
Feature nemo support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The text-domain should stay the same as there's no specific string that says : Nautilus and there will never be , so there's no need to duplicate the efforts :p |
|
The same with NemoPropertyPage & NemoLocation, those objects will be the same for both file managers. The whole things is to avoid duplicating the same code on two different files and fixing bugs/adding features on both of them. This way, the core will be the same & the nautilus/nemo-git/git.py will always stay the same |
|
I thought of avoiding Nautilus in Nemo package at all. I'll change it. |
|
Perfect ! Thanks! I will release a new version this weekend |
bilelmoussaoui
added a commit
that referenced
this pull request
Jun 2, 2017
* alpha code, nemo support * few code cleaning add nemo-git folder * minor improvements * add Nemo information on README & uninstall file * ues gtk.builder for ui's (just the beginning.. * Feature nemo support (#21) * Add support to Nemo * Rename text domain * Fix class name issue * add nemo support (clean the code), add appdata file, compile gresource * working again * make the metainfo file translatable * fixes all the bugs * correct manual installation method * correct nemo-git * bump version number, update uninstall script * remove duplicate code, beautify & sort imports * minor improvement * add the possiblity to list the modified files by clicking on the icon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.