portal: update create_item() to return portal::Item #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm for future commits, please describe why the change is needed not what the change itself. In this case, I would have instead mentioned the use case of wrapping the portal::Item` in the server side implementation. |
This change updates the oo7::portal::Keyring::create_item() to return oo7::portal::Item instead of () We need this change for the server side implementation. In server/daemon side we are wrapping the return value of create_item() inside a struct. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
warusadura
force-pushed
the
update_create_item
branch
from
9f62c43
to
355c9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
oo7::portal::Keyring::create_item()to returnoo7::portal::Iteminstead of()We need this change for the server side implementation. In server/daemon
side we are wrapping the return value of
create_item()inside a struct.