Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace components #19

Closed
bilfeldt opened this issue Dec 16, 2022 · 0 comments · Fixed by #24
Closed

Namespace components #19

bilfeldt opened this issue Dec 16, 2022 · 0 comments · Fixed by #24
Milestone
v1.0

Comments

@bilfeldt
Copy link
Owner

All components are currently prefixed with flash like

<x-flash-alert ... />

but we should use vendor namespacing like

<x-flash::alert ... />`

which is done by registering the components using componentNamespace() which is not supported by the spatie/laravel-package-tools package.
@bilfeldt bilfeldt added this to the v1.0 milestone Dec 16, 2022
@bilfeldt bilfeldt mentioned this issue Dec 16, 2022
Merged
bilfeldt added a commit that referenced this issue Dec 16, 2022
@bilfeldt
Merge pull request #24 from /issues/19
b7c7ca9 
Use namespace for components instead of prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Use namespace for components instead of prefix bilfeldt/laravel-flash-message
1 participant
@bilfeldt