支持短信登录中的滑动验证 #114
Merged
支持短信登录中的滑动验证 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForgQi
reviewed
Aug 11, 2023
| Some(ResponseValue::Value(data)) | ||
| if !data["recaptcha_url"].as_str().unwrap_or("").is_empty() => | ||
| { | ||
| let url = data["recaptcha_url"].as_str().unwrap().to_string(); |
There was a problem hiding this comment.
其实我觉得 captcha_key 和 recaptcha_url 都用 unwrap_or 好一些。match 过程中出 Error 的话应该整个函数直接返回了，最后拿到的是 send sms error，隐藏了 res 的原始内容。用 unwrap_or 的做法不会在匹配过程中返回错误，当两种情况都匹配不上就在最后统一返回 Err(Kind::Custom(res.to_string()))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加了支持验证码的短信登录 API。用户可以自己在浏览器内完成滑动验证后输入验证结果，并通过回调继续登录。目前只在 biliup 命令行工具里添加此功能，stream_gears 应该也可以用类似的方法。