Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Don't log api token, log headers instead #5

Closed

Conversation

nurazem
Copy link
Contributor

@nurazem nurazem commented Apr 6, 2016

No description provided.

@billforward-alex
Copy link
Contributor

Unfortunately — in the STDOUT Ruby logger of Ruby 1.8.7 — objects converted to strings look absolutely horrendous:

I, [2016-04-06T18:35:01.540179 #28949]  INFO -- : headers: acceptapplication/jsonAuthorizationBearer NOPE-NOPE-NOPE

I wrapped it with a JSON.pretty_generate:

I, [2016-04-06T18:31:37.838949 #28786]  INFO -- : headers: {
  "accept": "application/json",
  "Authorization": "Bearer NOPE-NOPE-NOPE"
}

This has been pushed with:
933b3a0

I have integrated these changes manually.

@nurazem
Copy link
Contributor Author

nurazem commented Apr 8, 2016

@billforward-alex Thanks for taking care of this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants