Fully unit tested consul-powered storage #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important note: |
lord2800
force-pushed
the
feat/consul-backend
branch
from
7ff261e
to
fcba91a
Compare
| function ConsulBackend(options) { | ||
| options = options || {}; | ||
| this._prefix = options.prefix || 'billimanjaro'; | ||
| delete options.prefix; |
There was a problem hiding this comment.
Why are you deleting the the array prefix?
There was a problem hiding this comment.
So I can send the remaining options, without the prefix (just in case for backwards compatibility), to the consul client.
|
👍 all of my comments seem minor. |
lord2800
force-pushed
the
feat/consul-backend
branch
from
fcba91a
to
50cafa3
Compare
|
Wanna give it another once-over @gabelimon? I cleaned up a few minor things and moved the |
|
👍 |
lord2800
added a commit
that referenced
this pull request
Sep 18, 2015
Fully unit tested consul-powered storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1 which is now ready to be merged.