Refactor filtering by attorney role #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter now works without having showing different tabs depending on the filter type. This means we can easily add new filters on top of the role, without having to add a new tab for each possible combination of the filters. It also allows to filter by more than one role at the time and reduce code duplication quite a bit.
Zoe7
commented
Oct 4, 2020
| <ul> | ||
| {{#each attorney in attorneys}} | ||
| <li class="col-sm-6 col-md-4 col-lg-3 single-attorney"> | ||
| <a class="card" href="{{pathFor 'attorneyView' data=attorney}}"> |
There was a problem hiding this comment.
data=attorney is the part that was missing in the previous PR
|
Brilliant, thank you @Zoe7. Merging. |
|
Just a quick note: I am waiting to see if anyone can help with the design of the filter (#128) before deploying to Heroku. The changes will not be live, but will be committed to the repo for eventual deployment. |
billimarie
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same PR as #125, but the routing to the attorney page should be fixed!