Function viz_gb_on_period not found

[darh78]

Hey Bill,

I'm glad to know my PRs were merged into the master branch.
I've reinstalled the package and I'm able to run the standings_on_date_bref without problems and get the new names on the table.
Nevertheless, the function viz_gb_on_period is not available in the package. I do not know if that is related to the difference in case-sensitive names in the function.

Regards.

Daniel.

[BillPetti]

Yes, it’s a case issue

[BillPetti]

I changed this in the R file. It was trying to export viz_gb_on_period, but the function was viz_GB_on_period. Try a reinstall and let me know if it works.

[darh78]

Hello @BillPetti,

Thanks for the feedback. I tried now and that problem is solved. Nevertheless, there is still an issue when trying to run it. It seems that it's not allowing separate function from "dplyr" to run.

[BillPetti]

I looked this over, a few things:

• it looks like separate is from tidyr, not dplyr
• you aren't importing the function, which you should (i.e. @importFrom tidyr separate)
• I would also default to naming the package explicitly just to make sure you don't run into any issues with multiple functions having the same name (i.e. tidyr::separate)

Can you fix this and then resubmit as a pull request?

[BillPetti]

@darh78 is this something you were going to fix and resubmit a pull request for?

[darh78]

@BillPetti sure!
I just hadn’t the time. I’ll try it this month.
Regards