-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including Fangraphs Player ID with Leaderboard Scrape #61
Comments
So, it used to be there, but looking at the url structure they changed it--basically because there are a ton more fields available. So, yes, but I'll need to update the url and subsequent formatting used in the function. |
Perfect. Is the pitcher leaderboard scrape coming soon? |
|
Did the fgid make it into this package? |
Yes |
I didn't see it when I ran it, and also didn't see it in the code. Not sure if I did something wrong on my end. |
It was there when I tested it. I’ll double check later. |
Any updates on this bug? |
Any updates on the bug. I just ran the function and didn't get the id. |
Unfortunately, this is not so much a bug as an enhancement. The data needs to pull retrieved in a different way to get the |
So looking this over, I should be able to extract |
That would be very cool. Unfortunately my programming skills aren't nearly as good as yours or I would offer to help. |
Without doing a full fork, and PR, how about something like?
|
This should be fixed now with the latest commit. Give it a reinstall and let me know if it brakes. |
I just reinstalled and tested it but didn't get the playerid field. I reinstalled using, |
Check and make sure your function’s content includes the new |
Great, I got it working, everything looks good. Separate question. Is there anyway to get a playid for the following function. daily_batter_bref() ? We get the names but it's difficult to match the names to an MLBID. Cheers, |
Probably, but please open a separate issue for it. |
Is there anyway that this can be included in the data scrape as a part of the data frame?
The text was updated successfully, but these errors were encountered: