Including Fangraphs Player ID with Leaderboard Scrape

[jestarr]

Is there anyway that this can be included in the data scrape as a part of the data frame?

[BillPetti]

So, it used to be there, but looking at the url structure they changed it--basically because there are a ton more fields available. So, yes, but I'll need to update the url and subsequent formatting used in the function.

[jestarr]

Perfect. Is the pitcher leaderboard scrape coming soon?

[BillPetti]

playerid will be added in the next package update. No plans right now for the pitcher leader board, but if someone wanted to tackle it in a pull request that would be groovy.

[jestarr]

Did the fgid make it into this package?

[BillPetti]

Yes

[jestarr]

I didn't see it when I ran it, and also didn't see it in the code. Not sure if I did something wrong on my end.

[BillPetti]

It was there when I tested it. I’ll double check later.

[jestarr]

Any updates on this bug?

[stevebit]

Any updates on the bug. I just ran the function and didn't get the id.

[BillPetti]

Unfortunately, this is not so much a bug as an enhancement. The data needs to pull retrieved in a different way to get the playerid returned with the leaderboards. I have not worked out an approach yet.

[BillPetti]

So looking this over, I should be able to extract playerid from the url for each player from the html of the page. Just need to find some time to do it.

[stevebit]

That would be very cool. Unfortunately my programming skills aren't nearly as good as yours or I would offer to help.

[jestarr]

Without doing a full fork, and PR, how about something like?

    find_possible_playerids <- leaders %>% html_nodes("a") %>% as.character()
    find_playerids <- find_possible_playerids[grep("statss.aspx\\?playerid=", find_possible_playerids)]
    find_playerids_split <- strsplit(find_playerids, "\\&") %>% sapply(., "[", 1)
    fangraphs_pg_playerids <- gsub("[[:alpha:]]*[[:punct:]]*[[:space:]]*", "", find_playerids_split)

[BillPetti]

This should be fixed now with the latest commit. Give it a reinstall and let me know if it brakes.

[stevebit]

I just reinstalled and tested it but didn't get the playerid field. I reinstalled using,
devtools::install_github("BillPetti/baseballr")

[BillPetti]

Check and make sure your function’s content includes the new playerid code. You may need to force the install to get the updated version, install_github(“BillPetti/baseballr”, force = TRUE).

[stevebit]

Great, I got it working, everything looks good.

Separate question. Is there anyway to get a playid for the following function. daily_batter_bref() ? We get the names but it's difficult to match the names to an MLBID.

Cheers,

[BillPetti]

Probably, but please open a separate issue for it.