Order list of currencies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will keep the default the same even if EUR is not the first one in the list anymore.
This makes it easier to reorder the species list.
It will make it easier for users to find their needed specie from the list. Fixes billthefarmer#1
|
OK, I have merged this into a branch. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR orders the currencies alphabetically.
The first preparatory commits restructure the code from separate lists for the different facets of a specie (name, longname, flag, symol) to a list of a single
Specieclass.Then this list is sorted alphabetically.
The advantage of this aproach over some automatic sorting is that makes it very easy to manually tweak the order to keep certain species on top while also making it easy to automatically sort the rest of the list with an IDE.
Fixes #1