Use Rails 6.1 config defaults #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using Rails 5.2 configuration defaults. This PR bumps config defaults up to parity with the Rails version (6.1) in preparation for moving to Rails 7.
The only substantive change resulted from the move to Zeitwerk for autoloading. Zeitwerk does not recognize capitalized namespaces like
OST, so I had to add an inflector to allow theOSTmodule to autoload correctly.The other solution would be to remove the inflector and change this module name to
Ost. I don't feel strongly either way.We should probably let the Rails 6.1 upgrade (#139) sit for a day or two to ensure no problems before merging this PR. I'm pushing the Rails 6.1 upgrade to Heroku now (morning of August 21, 2022).
Addresses a portion of #134