Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/get rank fix #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/get rank fix #76

wants to merge 2 commits into from

Commits on Jan 9, 2021

  1. added a comment to the Seasons class

    @Jackywathy
    Jackywathy committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    a4a2236 View commit details
    Browse the repository at this point in the history

  2. Fixed get_rank to return the correct rank 

    - Rank.rank is now (correctly) the string name of the rank. Access the raw rank object via `rank_obj`. This is for compatibility with previous API.
- added a way to index into the ranked collection, handling the case were the rank was unranked
- added old ranking bands to pre ember rise seasons
- small tweaks to readability to rankinfo objects when printed
    @Jackywathy
    Jackywathy committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    38479fb View commit details
    Browse the repository at this point in the history