Patch "esoteric" static-file collection #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a tempalte tag to generate the content fix the issue with the inconsitent widths
allows reuse across the application
Configure the colours of form using css variables on theme class extend form objects with fieldsets, that enable flexability with rendering. This has been done very naively for now by looping over the fields multiple times add url from favorite card to form back button on from, uses the history object so if you hard refresh onto the page, the back button will take you off the page. refactor babybuddy/templates/babybuddy/form.html to either render desktop version create new base tempalte for mobile forms
Currently the ui uses lots of drop downs, radio selects are better for mobile views, but can also work well on desktop ui This commit creates the radio select widget
Currently it takes a lot of effort to add a new form, copy pasting a bunch of code importing form everywhere. and it is easy to make a mistake in the inheritance. Define extra fields required for the mobile form on the base core class, Use a generic template for the mobile views since all variance is defined in the constants array Just do simple inheritance view the view class, this allows extension if someone wants to but simpler implementation for now.
Field set allows you to use custom templates for fields, the layout it tempalte is required to exist, and is automatically pulled via include
we can create a nursing form later
Users should be able to select on a device, to use the mobile site. for this reason i have made the setting on local storage. clicking on the settings dropdown will cause mobile to become default, switching to desktop from mobile will make desktop the default.
billybonks
force-pushed
the
mobile
branch
4 times, most recently
from
0fe65e8
to
23eeafa
Compare
|
@MrApplejuice I am currently waiting to get the backports babybuddy#760 into the existing ui before continuing on this branch |
|
Hey, yes sure, no worries! I just wanted to chip in because it seemed that you got stuck somehow. Feel free to just close this PR if you do not need the information from here anymore. It was just meant as a PR that you can use to scrape information from that is useful to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to fix the static file collection. Please edit before merging! I removed some code because the linter did not pass, for example.
What is also missing: