Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Refactor tags #92

Open
billyquith opened this issue Jan 27, 2018 · 3 comments
Open

Remove/Refactor tags #92

billyquith opened this issue Jan 27, 2018 · 3 comments
Assignees
@billyquith
Labels
change
Projects
Ponder V3
Milestone
3.0 - Big refactor

Comments

@billyquith
Copy link
Owner

TagHolder is the base class for all declared types. This is a specialised use of the types and seems like it should be in the client code. Each TagHolder contains a std::map, which is also an unwanted overhead.

Perhaps this could be removed and custom user data attached to objects?

I'll remove this for now and rethink it later.
@billyquith billyquith self-assigned this Jan 27, 2018
@billyquith
Copy link
Owner Author

We'll add a common base class ponder::Type for now.

@billyquith
Copy link
Owner Author

In dev branch.

@billyquith billyquith mentioned this issue Jan 27, 2018
Open
billyquith added a commit that referenced this issue Jan 28, 2018
@billyquith
Remove TagHolder (#92)
ea50b7e 
- This was the base for all types.
- An unnecessary overhead when unused.
- Perhaps could add something similar with user data.
@billyquith billyquith added this to To do in Ponder V3 Apr 29, 2018
@billyquith
Copy link
Owner Author

See #98 for mechanism for this.

@billyquith billyquith added this to the 3.0 - Big refactor milestone Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billyquith billyquith

Labels
change
Projects
Ponder V3
  
To do
Milestone
3.0 - Big refactor
Development

No branches or pull requests
1 participant
@billyquith