fixed brightness when using external screens #24
Conversation
|
Thanks. I will take a look at this some time later in the week. |
| @@ -16,6 +16,9 @@ | |||
| #include <pthread.h> | |||
| #include "Log.h" | |||
|
|
|||
| int DisplayServicesSetBrightnessWithType( int, int, int, int); //now the compiler knows, what the signature looks like. | |||
There was a problem hiding this comment.
This is not used anywhere. Please remove.
| kern_return_t ret = KERN_RETURN_MAX; | ||
| err = CGGetOnlineDisplayList(8, displayIDs, &max); | ||
| if(err != kCGErrorSuccess) { |
There was a problem hiding this comment.
Please try to maintain the same code style as the rest of the project. In this project left braces ({) go to the next line.
|
|
||
| err = CGGetOnlineDisplayList(8, displayIDs, &max); | ||
| if(err != kCGErrorSuccess) { | ||
| false; |
There was a problem hiding this comment.
This should be return false;.
|
In addition to my comments above your patch changes EnergyBar to control the builtin display instead of the main display.
|
|
@billziss-gh @clemenstyp The default touchbar behaviour appears to change the built in display for me when using an external monitor, at the same time however my external doesn't offer software brightness control. It would be good if we had a setting at least that let EnergyBar change the built in diplays brightness rather than the main display. |
I fixed the brightness, so that is cycles through all displays and changes the build-in one.
The last solution did not work, when you had a second screen attached, that you used a your main display.