Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this can be optimized #5

Closed
github-actions bot opened this issue Jun 1, 2022 · 3 comments
Closed

this can be optimized #5

github-actions bot opened this issue Jun 1, 2022 · 3 comments
Assignees
Labels

Comments

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

anime on every call creates a new anime instance.

we can create an anime instace with necessary animation before hover method

but this will require some extra checks like component is mounted

const hover = (state: boolean) => {

};

// hovering
//
// TODO: this can be optimized
// `anime` on every call creates a new anime instance.
// we can create an anime instace with necessary animation before hover method
// but this will require some extra checks like component is mounted
//
const hover = (state: boolean) => {
  revealLocation.value = state;
  state
    ? anime({ targets: footerCoordinatesRef.value, ...slightlyScale(1.15) })
    : anime({ targets: footerCoordinatesRef.value, ...normalScale(1) });
};
</script>

<style lang="scss" scoped>
@github-actions github-actions bot added the todo label Jun 1, 2022
bim-ba added a commit that referenced this issue Oct 28, 2023
chore((README.md)): clean up
chore(packages): updated packages
chore(shims): updated shims
refactor: refactored all files; package updates are taken
refactor(animations): `anime.js` and `@vueuse/motion`/`@vueuse/gesture` are coordinated now
refactor(floppy disks structure): refactored floppy disks structure from `Array` to `DoublyLinkedList`
fix: #6, #5, #4
@github-actions
Copy link
Author

Closed in 9afc726

2 similar comments
@github-actions
Copy link
Author

Closed in 9afc726

@github-actions
Copy link
Author

Closed in 9afc726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant