Rename data manager again, fix data manager. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work I will have a look. Did you see that there was already a customer in the iuc gitter chat? |
|
I did, and suddenly I'm wondering if we should just have the data manager build blastn and blastp in the same operation, calling the table |
|
Hmm so you mean that we have a select to switch from fasta with agct and a fasta that contains protein sequences... I think it might be better to separate them? |
bimbam23
pushed a commit
that referenced
this pull request
Feb 21, 2019
fix output filtering and debug test of novel_splicesite_outfile option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed it to data_manager_blastn_database_builder so that it would have the same pattern as other -iuc data managers. I've tested with both a history fasta and an all_fasta fasta, both seem to work.