-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix key-error when response returns no json #219
Conversation
Change some comments, fixed some typo's
Pull from master
Many thanks for this, will definetly include the extended anonymizer! |
I will look at this, but, my car supports RangeMaps but the request returns 500 most of the times, sometimes 200. So, my fix wil handle those request returning no valid key in the request.json(). This has nothing to do with the car support a service or not... |
Ah, that is good to know! Then it is for sure better to also account for this! |
@rikroe PR #213 seems good to me! No issues found... |
Thanks! Regarding |
I tried to get a valid response the last few days, but i only get 500’s, not a single 200 unfortunately. I agree on adding the #213 to resolve this, although my Rangemap != UNSUPPORTED |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Breaking change
Proposed change
When certain service if not available (RangeMap for example), the response.json() does not contain the service-key.
This PR fixes the unhandled exception and prevents stopping service-loop.
Type of change
Additional information
Also extended the data_anonymizer :D
Checklist