Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login for north_america and rest_of_world #252

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 16, 2020

Proposed change

BMW changed the login secrets... Again... They did it a couple of weeks back, but reverted.
We're now using the new secrets for north_america and rest_of_world, as china is still using the old secrets.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

@gps1539, @deluxestyle, @nichwang88: Could you please test this?

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe requested a review from gerard33 November 16, 2020 19:00
@gerard33
Copy link
Member

Wonder why they reverted the change 🤷‍♂️

@deluxestyle
Copy link

Just copied the files to my homeassistant and it works.
I'm using "rest_of_world"
thank you

@rikroe rikroe merged commit 86cfb94 into bimmerconnected:master Nov 16, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
@rikroe rikroe deleted the fix-login branch December 9, 2021 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants