Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHARGE_NOW remote service #395

Merged
merged 2 commits into from Jan 9, 2022
Merged

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Jan 4, 2022

Proposed change

Add the CHARGE_NOW service. Based on #387, but cannot test due to not having an EV.

@Nhubbers: Are you able to try this out?

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #395 (cb9c2e4) into master (42b7386) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   96.91%   96.93%   +0.02%     
==========================================
  Files           8        8              
  Lines         939      946       +7     
==========================================
+ Hits          910      917       +7     
  Misses         29       29              
Flag Coverage Δ
3.10.x 96.82% <100.00%> (+0.02%) ⬆️
3.6 96.92% <100.00%> (+0.02%) ⬆️
3.7 96.81% <100.00%> (+0.02%) ⬆️
3.8 96.82% <100.00%> (+0.02%) ⬆️
3.9 96.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bimmer_connected/remote_services.py 95.55% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b7386...cb9c2e4. Read the comment docs.

@Nhubbers
Copy link

Nhubbers commented Jan 7, 2022

@rikroe Will definitely give this a shot! thanks!

@rikroe rikroe requested a review from gerard33 January 9, 2022 15:21
Copy link
Member

@gerard33 gerard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rikroe rikroe merged commit d987165 into bimmerconnected:master Jan 9, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2022
@rikroe rikroe deleted the charge-now branch June 2, 2022 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants