Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in README.rst #53

Merged
merged 2 commits into from
Mar 18, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ I wrote this library as I want to include it in Home Assistant.

Compatibility
-------------
This works with BMW vehicles with a Connected Driver account.
This works with BMW vehicles with a ConnectedDrive account.
So far it is tested on vehicles with a 'NBTEvo', 'EntryEvo', 'NBT', or 'EntryNav' navigation system.
If you have any trouble with other navigation systems, please create an issue
with your server responses (see next section).
Expand Down Expand Up @@ -49,6 +49,9 @@ and
`add the files as attachment <https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/>`_
to the issue.

Please add your model and year to the title of the issue, to make it easier to organize. If you know the "chassis code" of your car, you can include that too. (For example, Googling "2017 BMW X5" will show a Wikipedia article entitled "BMW X5 (F15)". F15 is therefore the chassis code of the car.)


**Note:** We will then use this data as additional test cases. So we will publish
(parts of) it (after checking for personal information again) and use
this as test cases for our library. If you do not want this, please
Expand All @@ -71,7 +74,7 @@ Thank you @gerard33, @m1n3rva, @kernelkraut, @robbz23, @lawtancool for your rese

This library is basically a best-of of other similar solutions I found,
yet none of them provided a ready to use library with a matching interface
to be used in Home Assistant and is available on pypi...
to be used in Home Assistant and is available on pypi.

* https://github.com/edent/BMW-i-Remote/blob/master/python/bmw.py
* https://github.com/jupe76/bmwcdapi/blob/master/bmwcdapi.py
Expand Down