Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Request: Mvn Repository #3

Open
mwong56 opened this issue Dec 14, 2017 · 48 comments
Open

Request: Mvn Repository #3

mwong56 opened this issue Dec 14, 2017 · 48 comments

Comments

@mwong56
Copy link

mwong56 commented Dec 14, 2017

Can we get this added to maven repository?

@joaopsilva
Copy link
Member

That was indeed in the plans, I will look into putting the library available from Maven Central in the next few days.

@mwong56
Copy link
Author

mwong56 commented Dec 16, 2017

Awesome! I've been using this for now https://jitpack.io/#binance-exchange/binance-java-api

@joaopsilva
Copy link
Member

JitPack is a great alternative indeed. In thea meantime, I have created a ticket with Sonatype (https://issues.sonatype.org/browse/OSSRH-36611), and if they are able to host the binaries, I will then synchronise them to Maven Central.

@aparsons
Copy link

aparsons commented Jan 5, 2018

+1 to getting this done

@guitcastro
Copy link

+1

@klaszlo8207
Copy link

+1

1 similar comment
@yiqinghe
Copy link

+1

@klaszlo8207
Copy link

The jitpack url is working like a charm. I am using with gradle and android with full of luck:)

@mehmetcansimsek
Copy link

+1

4 similar comments
@volodymyr-shulga
Copy link

+1

@big-andy-coates
Copy link

+1

@zagorulkinde
Copy link

+1

@pako-g
Copy link

pako-g commented Feb 22, 2018

+1

@mustii82
Copy link

Still not available please upload it and make a jar version to easy import this Library

@naeem-github
Copy link

Please do this ASAP

@vladimirus
Copy link

in the meantime https://jitpack.io/ is quite good

       <repositories>
		<repository>
		    <id>jitpack.io</id>
		    <url>https://jitpack.io</url>
		</repository>
	</repositories>
       <dependency>
	    <groupId>com.github.binance-exchange</groupId>
	    <artifactId>binance-java-api</artifactId>
	    <version>master-SNAPSHOT</version>
	</dependency>

@big-andy-coates
Copy link

Any update on this @joaopsilva?

@afaslan
Copy link

afaslan commented Mar 18, 2018

+1

5 similar comments
@tach1685
Copy link

+1

@carvalho2707
Copy link

+1

@tadaskrisciunas
Copy link

+1

@arild
Copy link

arild commented May 24, 2018

+1

@yaserhadi
Copy link

+1

@noonhub
Copy link

noonhub commented Jul 27, 2018

The README seems to claim this is in Maven but a search only shows other libraries and a fork. ¯_(ツ)_/¯

@tach1685
Copy link

tach1685 commented Aug 5, 2018

Hi joaopsilva, Any news on where this issue is on the roadmap?

@malkusch
Copy link

malkusch commented Aug 5, 2018

@noonhub No it doesn't:

Install library into your Maven's local repository by running mvn install

@wrone
Copy link

wrone commented Aug 22, 2018

+1

@adcar
Copy link

adcar commented Sep 7, 2018

+1

@qingyang-id
Copy link

+1

1 similar comment
@antonvalletas
Copy link

+1

@mutellipiqbal
Copy link

Maven Pom file could not find dependency version.
version fualt

@guicastrofer
Copy link

+1
I have the same problem on my pom.xml, mentioned above.

zheh12 pushed a commit to zheh12/binance-java-api that referenced this issue Mar 19, 2019
@joaovitormarques
Copy link

Hello @joaopsilva , any news on this?

@aparsons
Copy link

I ran into a problem where my dependency was cached and the API calls were broken. Adding -SNAPSHOT to the dependency version will ensure you're using the latest version from jitpack.

repositories {
  maven { url "https://jitpack.io" }
}

dependencies {
  implementation 'com.github.binance-exchange:binance-java-api:master-SNAPSHOT'
}

On a side note, @joaopsilva please fix this. It's easy to do!

@freekode
Copy link

3 years and still open?

@rotilho
Copy link

rotilho commented Dec 14, 2020

Any progress on it? It should be a simple task.

@chinnaxs
Copy link

chinnaxs commented Jan 2, 2021

Also in favor of getting this to the maven repo

@omerg
Copy link

omerg commented Jan 23, 2021

I've forked the project and then published to Maven Central Repository. Here is the dependency information:

<dependency>
  <groupId>tr.com.lucidcode</groupId>
  <artifactId>binance-api-client</artifactId>
  <version>1.0.0</version>
</dependency>

@carlspring
Copy link

Any updates on making this available from Maven Central?

@adkr
Copy link

adkr commented Jun 6, 2021

Shame... Almost 4 years and this issue is still opened.
That's really bad from technical, public relations and brand perspective.

@infinic
Copy link

infinic commented Jan 11, 2022

+1

@kwladyka
Copy link

kwladyka commented Mar 13, 2022

Any rationale why the library is not in mvn?

Edit:
I didn't check it yet, but it looks like the https://github.com/binance/binance-connector-java it the right one.

@carlspring
Copy link

@kwladyka ,

Yes, the rationale is perfectly clear -- this project has been dead for a long while.

@kwladyka
Copy link

The project lucks of "deprecated" word in readme.md or should be archived in github. It is not obvious in first steps with Binance API.

@carlspring
Copy link

@kwladyka : If you check the commit history, you'll see that there has been no real activity on the project since it won the bounty for a Java implementation of a library for Binance. I don't think that the original author cares about further developing this. You can easily arrive to the same conclusion, if you have a look at the number of pull requests which have been made by various contributors and have not been reviewed, or merged.

@kwladyka
Copy link

I know. Just I am saying it is not friendly approach for developers :)

@carlspring
Copy link

@kwladyka : I agree, :)

@joaopsilva
Copy link
Member

Hi @kwladyka , @carlspring , I did try to have the project on Maven right from the start, but since the groupId was set to com.binance.api, it needed the approval from someone at Binance (i.e. an email sent from "@binance.com"), and even though I requested it, the email was never sent. So moving forward the groupId would need to be renamed, or we would need to press Binance again.

Another issue is given the sensitivity of this API, and how it can have full access to your account for trading purposes, it's usually recommended to run a local audited copy instead of just blindly trusting a binary from Maven, but ultimately that depends on the trust-level of the developer, and I agree there should be an option.

Finally, I have been busy with multiple other projects since I released this API, and I no longer have time to actively maintain it, so I would happily accept new developers to take over; in case you are interested, please let me know, I will open an issue soon about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests