Skip to content

Commit

Permalink
Weight adjustment
Browse files Browse the repository at this point in the history
  • Loading branch information
@Ninj0r
Ninj0r committed Jan 14, 2018
1 parent 0bdfec2 commit 4f1a126
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---- 2018-01-14
* GET /api/v1/aggTrades weight changed to 2
* GET /api/v1/klines weight changed to 2
* GET /api/v3/order weight changed to 2
* GET /api/v3/allOrders weight changed to 100
* GET /api/v3/account weight changed to 20
* GET /api/v3/myTrades weight changed to 100

15 changes: 8 additions & 7 deletions rest-api.md
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Public Rest API for Binance (2017-12-01)
# Public Rest API for Binance (2018-01-14)
# General API Information
* The base endpoint is: **https://api.binance.com**
* All endpoints return either a JSON object or array.
Expand Down Expand Up @@ -469,7 +469,7 @@ Get compressed, aggregate trades. Trades that fill at the time, from the same
order, with the same price will have the quantity aggregated.

**Weight:**
1
2

**Parameters:**

Expand Down Expand Up @@ -508,7 +508,7 @@ Kline/candlestick bars for a symbol.
Klines are uniquely identified by their open time.

**Weight:**
1
2

**Parameters:**

Expand Down Expand Up @@ -853,7 +853,7 @@ GET /api/v3/order (HMAC SHA256)
Check an order's status.

**Weight:**
1
2

**Parameters:**

Expand Down Expand Up @@ -969,7 +969,7 @@ GET /api/v3/allOrders (HMAC SHA256)
Get all account orders; active, canceled, or filled.

**Weight:**
1
100

**Parameters:**

Expand Down Expand Up @@ -1013,7 +1013,7 @@ GET /api/v3/account (HMAC SHA256)
Get current account information.

**Weight:**
1
20

**Parameters:**

Expand Down Expand Up @@ -1055,7 +1055,7 @@ GET /api/v3/myTrades (HMAC SHA256)
Get trades for a specific account and symbol.

**Weight:**
1
100

This comment has been minimized.

Sign in to view

Copy link
@blaskovic

blaskovic Jan 14, 2018

This change without notice in advance?? WOW, not cool!

This comment has been minimized.

Sign in to view

Copy link
@kennym

kennym Feb 16, 2018

what does this do?

**Parameters:**

Expand Down Expand Up @@ -1258,3 +1258,4 @@ The `MAX_ALGO_ORDERS` filter defines the maximum number of "algo" orders an acco
}
```


22 comments on commit 4f1a126

@lutzleonhardt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ninj0r Do you plan to reduce the weights later? Thx for the information.

@magicdude4eva
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change broke CoinTracking.info

@blaskovic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change broke nearly everything which was working with API :D

@CoinTracking
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry guys, but with a weight change to 100 on the myTrades endpoint, this API is definitely no longer usable. Especially, since this endpoint needs to be called for every single trading-pair.

We will temporarily pause the Binance API on CoinTracking until we get a reply from them.
In the meantime, you can use the Binance CSV/XLS import or just use any other exchange.

@gen4sp
Copy link

@gen4sp gen4sp commented on 4f1a126 Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are weights?

@masterkain
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change broke pandoon.cash too

@TeunKooijman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These weight changes make the REST API almost completely unusable. Either put them back to 1, or (preferably) add additional endpoints for querying over all possible symbols with a single request. This goes for endpoints such as /api/v3/myTrades, as well as /api/v3/allOrders and probably more. You guys need to realise that not everything can be solved through websocket connections, as well as the fact that throttling the polling to this extreme degree is infeasible for many of our use-cases.

@CfirTsabari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoinTracking hi just to let u know they changed the my trades weight to 20

@magicdude4eva
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if @Ninj0r is part of the official Binance team, but it would help to perhaps point development users of the API to a place where we can subscribe/be informed about those changes. Surely those decisions do not come overnight?

@CoinTracking
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CfirTsabari Thanks. It's still 20 times higher than before, but it should work better now.
We've already reduced the API call speed yesterday. Binance imports should work again on CoinTracking, but it will take more time to get all transactions. I'm saying "should work", since the Binance servers are still very slow and sometimes they just reply with a gateway error.

@Zman123
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoinTracking API import still not working....imported 8 transactions (my deposits & withdrawls), but none of the rest of my transactions.

@masterkain
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on pandoon.cash we fixed it but it's extremely slow for many users, please consider adding a single endpoint to list trades 👍

@rknkr
Copy link

@rknkr rknkr commented on 4f1a126 Jan 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binance should fix this issue as fast as it can... they earn millions in hours.. they have the capital.. they can expand their teams, and shorten the time line to fix things if they plan to , of course if they want to be successfully running in the long term.. because these kind of issues pullout clients from exchanges including from binance.

@EdisonTing
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoinTracking.info API import still not working. Pls find a solution asap.

@omdv
Copy link

@omdv omdv commented on 4f1a126 Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to move to another exchange I guess

@pth0rn
Copy link

@pth0rn pth0rn commented on 4f1a126 Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please allow a request to get all account trades, instead of needing to make separate requests for every trade pair

@rakodev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Binance plz, allow us to get all trades in one request

@SpartanDigitalDotNet
Copy link

@SpartanDigitalDotNet SpartanDigitalDotNet commented on 4f1a126 Jan 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference on breaking changes such as these, use standard API versioning, e.g. ../v4/

@mikecann
Copy link

@mikecann mikecann commented on 4f1a126 Feb 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come on guys get this sorted! Whats the problem? If its a server resource thing, surely Binance can afford to buy more servers?!

@ingeniumdesign
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz start the service!

@dav1app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still broken?

@bouteill
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears still broken on CoinTracking. Any news?

Please sign in to comment.