Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Aizad/WALL-3036/Create/Add MT5 account modal issues #12183

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Dec 12, 2023

Changes:

Issue 2:

  • fix minor styling issues
    Issue 3:
  • show error messages onblur
    Issue 4:
  • fix spacing between the heading and subtitle
    Issue 5
  • handle error message for incorrect password inside both MT5 and DxTrade

Screenshots:

Issue 2:
Screenshot 2023-12-13 at 11 22 40 AM

Issue 3:
image

Issue 4:
image

Issue 5:
https://github.com/binary-com/deriv-app/assets/103104395/ad78016b-d504-4a03-a123-7e997c0afc5f

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 13, 2023 4:54am

@coveralls
Copy link

coveralls commented Dec 12, 2023

Coverage Status

coverage: 31.365% (-0.006%) from 31.371%
when pulling e1324fa on aizad-deriv:aizad/WALL-3036/CreateMT5ModalIssues
into 9c7a251 on binary-com:master.

Copy link
Contributor

github-actions bot commented Dec 12, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12183](https://github.com/binary-com/deriv-app/pull/12183)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-3036createmt5m-f9e0d3.binary.sx?qa_server=red.derivws.com&app_id=31385
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-3036createmt5m-f9e0d3.binary.sx
- **App ID**: `31385`

Copy link
Contributor

github-actions bot commented Dec 12, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 69
🟧 Best practices 83
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-3036createmt5m-f9e0d3.binary.sx/

wojciech-deriv
wojciech-deriv previously approved these changes Dec 12, 2023
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@mahdiyeh-deriv mahdiyeh-deriv merged commit 46f5d05 into binary-com:master Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants