Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] Jim/FEQ-1824/use remote config data to toggle datadog on or off #13946

Conversation

jim-deriv
Copy link
Contributor

@jim-deriv jim-deriv commented Mar 4, 2024

Changes:

  • Implemented logic to toggle datadog on or off based on the value set in the remote config

Note

  • There's is a better way to achieve this introduced in v5.10.0, but it's still experimental. Therefore, It's best to leave it this way for now.

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 6, 2024 7:53am

Copy link
Contributor

github-actions bot commented Mar 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13946](https://github.com/binary-com/deriv-app/pull/13946)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-feq-1824use-firebase-re-14e5b7.binary.sx?qa_server=red.derivws.com&app_id=32816
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-feq-1824use-firebase-re-14e5b7.binary.sx
- **App ID**: `32816`

Copy link
Contributor

github-actions bot commented Mar 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-feq-1824use-firebase-re-14e5b7.binary.sx/

@coveralls
Copy link

coveralls commented Mar 4, 2024

Coverage Status

coverage: 45.123% (+7.7%) from 37.379%
when pulling c0c8d4e on jim-deriv:jim/feq-1824/use-firebase-remote-config-to-toggle-datadog
into aa63424 on binary-com:master.

@jim-deriv jim-deriv marked this pull request as draft March 4, 2024 06:16
…-1824/use-firebase-remote-config-to-toggle-datadog
…-1824/use-firebase-remote-config-to-toggle-datadog
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@jim-deriv jim-deriv marked this pull request as ready for review March 6, 2024 08:48
@jim-deriv jim-deriv merged commit 7f53449 into binary-com:master Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants