Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEQ] Sergei / FEQ-2105 / Add try catch for exchange rates subscription #14673

Merged
merged 5 commits into from
Apr 25, 2024
Merged

[FEQ] Sergei / FEQ-2105 / Add try catch for exchange rates subscription #14673

merged 5 commits into from
Apr 25, 2024

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Apr 17, 2024 •
edited
Loading

Changes:

Add try/catch for exchange_rates subscription to prevent console error

Screenshots:

nothing changed in ui

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 22, 2024 2:20pm

heorhi-deriv
heorhi-deriv previously approved these changes Apr 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/14673](https://github.com/binary-com/deriv-app/pull/14673)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-hot-fixwrap-by-try-catch.binary.sx?qa_server=red.derivws.com&app_id=24160
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-hot-fixwrap-by-try-catch.binary.sx
- **App ID**: `24160`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-hot-fixwrap-by-try-catch.binary.sx/

@sergei-deriv sergei-deriv changed the title [FIX] Sergei / Add try catch for exchange rates subscription [FEQ] Sergei / FEQ-2105 / Add try catch for exchange rates subscription Apr 17, 2024
@coveralls
Copy link

coveralls commented Apr 17, 2024 •
edited
Loading

Coverage Status

coverage: 40.338% (-0.04%) from 40.379%
when pulling 504fcee on sergei-deriv:sergei/hot-fix/wrap-by-try-catch
into a2a9edb on binary-com:master.

farrah-deriv
farrah-deriv previously approved these changes Apr 19, 2024
View reviewed changes
habib-deriv
habib-deriv previously approved these changes Apr 19, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@likhith-deriv likhith-deriv merged commit fe8d4a5 into binary-com:master Apr 25, 2024
7 checks passed
likhith-deriv pushed a commit that referenced this pull request Apr 25, 2024
@sergei-deriv @likhith-deriv
[FEQ] Sergei / FEQ-2105 / Add try catch for exchange rates subscripti…
55e562c 
…on (#14673)

* feat: add try catch

* fix: repair tests

* feat: add console.warn as error handler for now

* feat: to prevent warning in the console add setExchangeRates as action to the client store
@shahzaib-deriv shahzaib-deriv mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameerul-deriv ameerul-deriv ameerul-deriv left review comments

@chrisgodfrey-deriv chrisgodfrey-deriv chrisgodfrey-deriv left review comments

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv left review comments

@habib-deriv habib-deriv habib-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

Assignees
No one assigned
Labels
AppStore Core
Projects
None yet
Milestone
No milestone
8 participants
@sergei-deriv @coveralls @farrah-deriv @habib-deriv @heorhi-deriv @ameerul-deriv @chrisgodfrey-deriv @likhith-deriv