-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WALL] Aizad/WALL-4435/Refactor Icons inside of Cashier #15700
Open
aizad-deriv
wants to merge
25
commits into
binary-com:master
Choose a base branch
from
aizad-deriv:aizad/refactor-cashier-icon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WALL] Aizad/WALL-4435/Refactor Icons inside of Cashier #15700
aizad-deriv
wants to merge
25
commits into
binary-com:master
from
aizad-deriv:aizad/refactor-cashier-icon
+214
−473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-refactor-cashier-icon.binary.sx/ |
wojciech-deriv
previously approved these changes
Jun 27, 2024
2251d6a
...res/cashier/modules/Transfer/components/TransferFormAccountCard/TransferFormAccountCard.scss
Show resolved
Hide resolved
wojciech-deriv
previously approved these changes
Jul 2, 2024
lubega-deriv
approved these changes
Jul 4, 2024
jim-deriv
previously approved these changes
Jul 4, 2024
thisyahlen-deriv
previously approved these changes
Jul 4, 2024
fff8fc8
nijil-deriv
approved these changes
Jul 9, 2024
wojciech-deriv
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
dark
from constants and updated the types.getTradingApp
fromhelpers.ts
WalletsAppLinkedWithWalletIcon
and replace it withWalletMakretCurrencyIcon
TransferfromAccountCard
andAppCard
to accomodateWalletMarketIcon
features/cashier/constants
WalletMarketIcon
to use familiar keys such asfinancial
,all
and etc.icon
file which stores all of theicons
withinsrc/constants
Link to CU: https://app.clickup.com/t/20696747/WALL-4435
Screenshots:
Please provide some screenshots of the change.