Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Aizad/WALL-4435/Refactor Icons inside of Cashier #15700

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Jun 19, 2024

Changes:

  • remove dark from constants and updated the types.
  • remove getTradingApp from helpers.ts
  • remove the use of WalletsAppLinkedWithWalletIcon and replace it with WalletMakretCurrencyIcon
  • refactor TransferfromAccountCard and AppCard to accomodate WalletMarketIcon
  • remove icons from features/cashier/constants
  • refactor WalletMarketIcon to use familiar keys such as financial, all and etc.
  • added icon file which stores all of the icons within src/constants

Link to CU: https://app.clickup.com/t/20696747/WALL-4435

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 9, 2024 8:24am

@coveralls
Copy link

Coverage Status

coverage: 38.859% (-6.0%) from 44.907%
when pulling 5b94b8c on aizad-deriv:aizad/refactor-cashier-icon
into 157972d on binary-com:master.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15700](https://github.com/binary-com/deriv-app/pull/15700)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-refactor-cashier-icon.binary.sx?qa_server=red.derivws.com&app_id=32110
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-refactor-cashier-icon.binary.sx
- **App ID**: `32110`

Copy link
Contributor

github-actions bot commented Jun 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-refactor-cashier-icon.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 41.85% (-3.1%) from 44.907%
when pulling f346348 on aizad-deriv:aizad/refactor-cashier-icon
into 157972d on binary-com:master.

wojciech-deriv
wojciech-deriv previously approved these changes Jun 27, 2024
@coveralls
Copy link

Coverage Status

coverage: 44.925% (+0.05%) from 44.871%
when pulling 2251d6a on aizad-deriv:aizad/refactor-cashier-icon
into 7619bde on binary-com:master.

wojciech-deriv
wojciech-deriv previously approved these changes Jul 2, 2024
@coveralls
Copy link

Coverage Status

coverage: 45.304% (+0.3%) from 44.987%
when pulling 487af19 on aizad-deriv:aizad/refactor-cashier-icon
into d05c8d7 on binary-com:master.

jim-deriv
jim-deriv previously approved these changes Jul 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 45.25% (-0.005%) from 45.255%
when pulling fff8fc8 on aizad-deriv:aizad/refactor-cashier-icon
into 23ec506 on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants