Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoketests.yml #15853

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update smoketests.yml #15853

merged 2 commits into from
Jul 1, 2024

Conversation

markodonnell-deriv
Copy link
Contributor

@markodonnell-deriv markodonnell-deriv commented Jun 28, 2024

Changes:

Essentially, the 'set env vars step' wasn't resolving the label collection correctly, so env.TEST_SUITE wasn't applied the correct setting.

Screenshots:

Please provide some screenshots of the change.

The set env vars step wasn't resolving the label collection correctly.
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 28, 2024 1:41pm

Copy link
Contributor

github-actions bot commented Jun 28, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Jun 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15853](https://github.com/binary-com/deriv-app/pull/15853)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-mark-pr-commit-v4.binary.sx?qa_server=red.derivws.com&app_id=23851
    - **Original**: https://deriv-app-git-mark-pr-commit-v4.binary.sx
- **App ID**: `23851`

Copy link
Contributor

github-actions bot commented Jun 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-mark-pr-commit-v4.binary.sx/

Copy link

sonarcloud bot commented Jun 28, 2024

Copy link
Contributor

package old new diff pct change
account 231 KB 231 KB 0 B 0% 🟢
appstore 779 KB 779 KB 0 B 0% 🟢
bot-web-ui 839 KB 839 KB +7 B +0.0% 🟢
cashier 684 KB 684 KB 0 B 0% 🟢
cashier-v2 3.0 MB 3.0 MB 0 B 0% 🟢
cfd 501 KB 501 KB 0 B 0% 🟢
core 6.6 MB 6.6 MB +5 B +0.0% 🟢
p2p 1002 KB 1002 KB 0 B 0% 🟢
p2p-v2 3.4 MB 3.4 MB 0 B 0% 🟢
reports 95 KB 95 KB 0 B 0% 🟢
trader 320 KB 320 KB 0 B 0% 🟢
wallets 3.7 MB 3.7 MB 0 B 0% 🟢

1 similar comment
Copy link
Contributor

package old new diff pct change
account 231 KB 231 KB 0 B 0% 🟢
appstore 779 KB 779 KB 0 B 0% 🟢
bot-web-ui 839 KB 839 KB +7 B +0.0% 🟢
cashier 684 KB 684 KB 0 B 0% 🟢
cashier-v2 3.0 MB 3.0 MB 0 B 0% 🟢
cfd 501 KB 501 KB 0 B 0% 🟢
core 6.6 MB 6.6 MB +5 B +0.0% 🟢
p2p 1002 KB 1002 KB 0 B 0% 🟢
p2p-v2 3.4 MB 3.4 MB 0 B 0% 🟢
reports 95 KB 95 KB 0 B 0% 🟢
trader 320 KB 320 KB 0 B 0% 🟢
wallets 3.7 MB 3.7 MB 0 B 0% 🟢

@coveralls
Copy link

Coverage Status

coverage: 45.525% (-0.002%) from 45.527%
when pulling f91591a on mark/pr-commit-v4
into 30775f4 on master.

@coveralls
Copy link

Coverage Status

coverage: 45.525% (-0.002%) from 45.527%
when pulling f91591a on mark/pr-commit-v4
into 30775f4 on master.

@coveralls
Copy link

Coverage Status

coverage: 45.528% (+0.001%) from 45.527%
when pulling f91591a on mark/pr-commit-v4
into 30775f4 on master.

@coveralls
Copy link

Coverage Status

coverage: 45.525% (-0.002%) from 45.527%
when pulling f91591a on mark/pr-commit-v4
into 30775f4 on master.

Copy link

@meeyun-deriv meeyun-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markodonnell-deriv markodonnell-deriv merged commit 036ad27 into master Jul 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants