Nada/p2 ps 234/buy sell ads message #8273

nada-deriv · 2023-04-17T06:10:59Z

Changes:

Please include a summary of the change and which issue is fixed below:

... content change in my-ads page for empty ads.

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-04-17T06:11:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 9:53am

github-actions · 2023-04-17T06:23:29Z

A production App ID was automatically generated for this PR. (log)

PR: Nada/p2 ps 234/buy sell ads message #8273
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-nada-deriv-nada-p2ps-234buy-sell-ads-message.binary.sx?qa_server=red.binaryws.com&app_id=32206
- Original: https://deriv-app-git-fork-nada-deriv-nada-p2ps-234buy-sell-ads-message.binary.sx
App ID: 32206

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8273](https://github.com/binary-com/deriv-app/pull/8273)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-234buy-sell-ads-message.binary.sx?qa_server=red.binaryws.com&app_id=32206
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-234buy-sell-ads-message.binary.sx
- **App ID**: `32206`

github-actions · 2023-04-17T06:23:56Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	18
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-234buy-sell-ads-message.binary.sx/

codecov-commenter · 2023-04-17T06:27:48Z

Codecov Report

Merging #8273 (9267743) into master (d5c38a0) will increase coverage by 20.67%.
Report is 192 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 9267743 differs from pull request most recent head 80f6814. Consider uploading reports for the commit 80f6814 to get more accurate results

@@             Coverage Diff             @@
##           master    #8273       +/-   ##
===========================================
+ Coverage    0.05%   20.73%   +20.67%     
===========================================
  Files         117     1538     +1421     
  Lines        3425    35927    +32502     
  Branches      893     7029     +6136     
===========================================
+ Hits            2     7449     +7447     
- Misses       3423    27732    +24309     
- Partials        0      746      +746

Files Changed	Coverage Δ
...ages/p2p/src/components/buy-sell/no-ads/no-ads.jsx	`0.00% <0.00%> (ø)`
...ackages/p2p/src/components/my-ads/my-ads-table.jsx	`0.00% <0.00%> (ø)`

... and 1575 files with indirect coverage changes

ameerul-deriv · 2023-04-17T06:39:22Z

packages/p2p/src/components/buy-sell/no-ads/no-ads.jsx

@@ -26,7 +33,9 @@ const NoAds = () => {
                        size='s'
                        weight='bold'
                    >
-                        <Localize i18n_default_text='No ads for this currency 😞' />
+                        <Localize
+                            i18n_default_text={is_ads_page ? 'You have no ads.' : 'No ads for this currency 😞'}


So just FYI you can't use ternaries wihin the localize as this will cause issues with translations, so make sure to separate it 👍

Suggested change

i18n_default_text={is_ads_page ? 'You have no ads.' : 'No ads for this currency 😞'}

{ is_ads_page ?

<Localize i18n_default_text='You have no ads.' />

: <Localize i18n_default_text='No ads for this currency 😞' />

}

ameerul-deriv · 2023-04-17T06:39:54Z

packages/p2p/src/components/buy-sell/no-ads/no-ads.jsx

                    >
-                        <Localize i18n_default_text='Create ad' />
+                        <Localize i18n_default_text={is_ads_page ? 'Create new ad' : 'Create ad'} />


same here ☝️

ameerul-deriv · 2023-04-17T06:43:53Z

packages/p2p/src/components/my-ads/my-ads-table.jsx

-            </Button>
-        </Empty>
-    );
+    return <NoAds is_ads_page={true} />;


Could you try this? Cause this usually works as well, if not, can ignore my comment

Suggested change

return <NoAds is_ads_page={true} />;

return <NoAds is_ads_page/>;

sonarcloud · 2023-04-17T06:54:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ameerul-deriv

LGTM

github-actions · 2023-06-17T00:21:34Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

gitguardian · 2023-07-03T09:17:48Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`837852c`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`837852c`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

sonarcloud · 2023-07-03T09:21:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.5% Duplication

github-actions · 2023-08-03T09:13:39Z

⏳ Generating Lighthouse report...

coveralls · 2023-08-03T09:47:54Z

coverage: 9.857% (+0.2%) from 9.643% when pulling 80f6814 on nada-deriv:nada/P2PS-234/buy-sell-ads-message into 419bc1b on binary-com:master.

farhan-nurzi-deriv · 2023-08-07T09:24:25Z

packages/p2p/src/components/buy-sell/no-ads/__tests__/no-ads.spec.jsx

+    useStores: jest.fn(() => mock_store_values),
+}));
+
+jest.mock('@sendbird/chat', () => ({


Non-blocking: Can we update jest.config instead? So we dont need to refactor these test files in the future 🙏

sonarcloud · 2023-08-11T09:36:33Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

DerivFE · 2023-09-18T09:12:06Z

✨ PR has been merged by Paimon the Release Bot

nada-deriv added 2 commits April 17, 2023 10:02

fix: change content for my-ads empty

e42b9d8

fix: updated with latest master

a759131

boring-cyborg bot added the P2P label Apr 17, 2023

vercel bot deployed to Preview April 17, 2023 06:23 View deployment

ameerul-deriv reviewed Apr 17, 2023

View reviewed changes

fix: pr comments fixed

9267743

vercel bot deployed to Preview April 17, 2023 07:04 View deployment

ameerul-deriv approved these changes Apr 17, 2023

View reviewed changes

farhan-nurzi-deriv approved these changes Apr 17, 2023

View reviewed changes

farrah-deriv previously approved these changes Apr 17, 2023

View reviewed changes

github-actions bot added the Stale label Jun 17, 2023

farrah-deriv removed the Stale label Jun 19, 2023

Merge branch 'master' into nada/P2PS-234/buy-sell-ads-message

837852c

vercel bot deployed to Preview July 3, 2023 10:17 View deployment

feat: merge conflicts fix

72d1d43

nada-deriv dismissed farrah-deriv’s stale review via 72d1d43 August 3, 2023 09:13

nada-deriv requested a review from nijil-deriv as a code owner August 3, 2023 09:13

feat: refactor code

9f1986b

vercel bot deployed to Preview August 3, 2023 09:54 View deployment

nada-deriv added 2 commits August 7, 2023 12:42

feat: added unit test, style fix

982b1c1

feat: reorder imports

57bc234

vercel bot deployed to Preview August 7, 2023 09:13 View deployment

farhan-nurzi-deriv approved these changes Aug 7, 2023

View reviewed changes

fix: issue with sendbird mock

194ddb3

farrah-deriv previously approved these changes Aug 8, 2023

View reviewed changes

fix: route to buy tab only in buy sell section

c4875a6

nada-deriv dismissed farrah-deriv’s stale review via c4875a6 August 11, 2023 08:49

vercel bot deployed to Preview August 11, 2023 09:05 View deployment

fix: failing test

80f6814

vercel bot deployed to Preview August 11, 2023 09:53 View deployment

farrah-deriv approved these changes Aug 14, 2023

View reviewed changes

DerivFE merged commit e9f5fc4 into binary-com:master Sep 18, 2023
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nada/p2 ps 234/buy sell ads message #8273

Nada/p2 ps 234/buy sell ads message #8273

nada-deriv commented Apr 17, 2023

vercel bot commented Apr 17, 2023 •

edited

Loading

github-actions bot commented Apr 17, 2023 •

edited

Loading

github-actions bot commented Apr 17, 2023 •

edited

Loading

codecov-commenter commented Apr 17, 2023 •

edited by codecov bot

Loading

ameerul-deriv Apr 17, 2023

ameerul-deriv Apr 17, 2023

ameerul-deriv Apr 17, 2023

sonarcloud bot commented Apr 17, 2023

ameerul-deriv left a comment

github-actions bot commented Jun 17, 2023

gitguardian bot commented Jul 3, 2023 •

edited

Loading

sonarcloud bot commented Jul 3, 2023

github-actions bot commented Aug 3, 2023 •

edited

Loading

coveralls commented Aug 3, 2023 •

edited

Loading

farhan-nurzi-deriv Aug 7, 2023

sonarcloud bot commented Aug 11, 2023

DerivFE commented Sep 18, 2023

-                            i18n_default_text={is_ads_page ? 'You have no ads.' : 'No ads for this currency 😞'}
+     { is_ads_page ?
+               <Localize  i18n_default_text='You have no ads.'  />
+               : <Localize  i18n_default_text='No ads for this currency 😞'  />
+     }

	return <NoAds is_ads_page={true} />;
	return <NoAds is_ads_page/>;

Nada/p2 ps 234/buy sell ads message #8273

Nada/p2 ps 234/buy sell ads message #8273

Conversation

nada-deriv commented Apr 17, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Apr 17, 2023 • edited Loading

github-actions bot commented Apr 17, 2023 • edited Loading

github-actions bot commented Apr 17, 2023 • edited Loading

codecov-commenter commented Apr 17, 2023 • edited by codecov bot Loading

Codecov Report

ameerul-deriv Apr 17, 2023

Choose a reason for hiding this comment

ameerul-deriv Apr 17, 2023

Choose a reason for hiding this comment

ameerul-deriv Apr 17, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Apr 17, 2023

ameerul-deriv left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 17, 2023

gitguardian bot commented Jul 3, 2023 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

sonarcloud bot commented Jul 3, 2023

github-actions bot commented Aug 3, 2023 • edited Loading

coveralls commented Aug 3, 2023 • edited Loading

farhan-nurzi-deriv Aug 7, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Aug 11, 2023

DerivFE commented Sep 18, 2023

vercel bot commented Apr 17, 2023 •

edited

Loading

github-actions bot commented Apr 17, 2023 •

edited

Loading

github-actions bot commented Apr 17, 2023 •

edited

Loading

codecov-commenter commented Apr 17, 2023 •

edited by codecov bot

Loading

gitguardian bot commented Jul 3, 2023 •

edited

Loading

github-actions bot commented Aug 3, 2023 •

edited

Loading

coveralls commented Aug 3, 2023 •

edited

Loading