Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indication for ads that are not listed #8296

Merged

Conversation

nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Apr 18, 2023

This pr is for the feature to implement a warning indication for the ads that will not be listed for the counterparties. When hovering over the indication, a tooltip will be shown indicating that the ad is hidden, and clicking on it will open a popup that states the reason for not showing the particular ad.

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • [] Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Apr 18, 2023
@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 6:28am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8296](https://github.com/binary-com/deriv-app/pull/8296)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-232indication-hi-b3ce6d.binary.sx?qa_server=red.binaryws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-232indication-hi-b3ce6d.binary.sx
- **App ID**: `32113`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-232indication-hi-b3ce6d.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #8296 (010e787) into master (d5c38a0) will increase coverage by 20.71%.
Report is 916 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 010e787 differs from pull request most recent head 797a4c8. Consider uploading reports for the commit 797a4c8 to get more accurate results

@@             Coverage Diff             @@
##           master    #8296       +/-   ##
===========================================
+ Coverage    0.05%   20.77%   +20.71%     
===========================================
  Files         117     1553     +1436     
  Lines        3425    36082    +32657     
  Branches      893     7067     +6174     
===========================================
+ Hits            2     7495     +7493     
- Misses       3423    27848    +24425     
- Partials        0      739      +739     
Files Coverage Δ
...ackages/p2p/src/components/my-ads/my-ads-table.jsx 0.00% <ø> (ø)
packages/p2p/src/stores/general-store.js 0.00% <0.00%> (ø)
packages/p2p/src/stores/my-ads-store.js 0.00% <0.00%> (ø)
.../p2p/src/components/my-ads/my-ads-row-renderer.jsx 0.00% <0.00%> (ø)
.../ad-error-tooltip-modal/ad-error-tooltip-modal.jsx 0.00% <0.00%> (ø)

... and 1587 files with indirect coverage changes

niloofar-deriv
niloofar-deriv previously approved these changes Apr 19, 2023
Copy link
Contributor

@niloofar-deriv niloofar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

niloofar-deriv
niloofar-deriv previously approved these changes Apr 19, 2023
Copy link
Contributor

@niloofar-deriv niloofar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just check the sonarcloud error 🙏

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Nov 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@farrah-deriv farrah-deriv merged commit a49f0bc into binary-com:master Nov 9, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants