-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: indication for ads that are not listed #8296
fix: indication for ads that are not listed #8296
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-232indication-hi-b3ce6d.binary.sx/ |
Codecov Report
@@ Coverage Diff @@
## master #8296 +/- ##
===========================================
+ Coverage 0.05% 20.77% +20.71%
===========================================
Files 117 1553 +1436
Lines 3425 36082 +32657
Branches 893 7067 +6174
===========================================
+ Hits 2 7495 +7493
- Misses 3423 27848 +24425
- Partials 0 739 +739
|
...es/p2p/src/components/modal-manager/modals/ad-error-tooltip-modal/ad-error-tooltip-modal.jsx
Outdated
Show resolved
Hide resolved
...es/p2p/src/components/modal-manager/modals/ad-error-tooltip-modal/ad-error-tooltip-modal.jsx
Outdated
Show resolved
Hide resolved
...es/p2p/src/components/modal-manager/modals/ad-error-tooltip-modal/ad-error-tooltip-modal.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
...es/p2p/src/components/modal-manager/modals/ad-error-tooltip-modal/ad-error-tooltip-modal.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Just check the sonarcloud error 🙏
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
This pr is for the feature to implement a warning indication for the ads that will not be listed for the counterparties. When hovering over the indication, a tooltip will be shown indicating that the ad is hidden, and clicking on it will open a popup that states the reason for not showing the particular ad.
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change