feat: chat box message after order creation #8405

nada-deriv · 2023-05-01T05:52:50Z

Changes:

Please include a summary of the change and which issue is fixed below:

... Chat box message after order creation.

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-05-01T05:52:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 14, 2023 7:41am

github-actions · 2023-05-01T06:09:13Z

A production App ID was automatically generated for this PR. (log)

PR: feat: chat box message after order creation #8405
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-nada-deriv-nada-p2ps-491chatbox-message.binary.sx?qa_server=red.binaryws.com&app_id=32220
- Original: https://deriv-app-git-fork-nada-deriv-nada-p2ps-491chatbox-message.binary.sx
App ID: 32220

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8405](https://github.com/binary-com/deriv-app/pull/8405)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-491chatbox-message.binary.sx?qa_server=red.binaryws.com&app_id=32220
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-491chatbox-message.binary.sx
- **App ID**: `32220`

github-actions · 2023-05-01T06:11:07Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-491chatbox-message.binary.sx/

packages/p2p/src/utils/chat-message.js

codecov-commenter · 2023-05-01T10:22:24Z

Codecov Report

Merging #8405 (c93b1c0) into master (d5c38a0) will increase coverage by 20.83%.
Report is 343 commits behind head on master.
The diff coverage is 18.75%.

❗ Current head c93b1c0 differs from pull request most recent head ac1cd05. Consider uploading reports for the commit ac1cd05 to get more accurate results

@@             Coverage Diff             @@
##           master    #8405       +/-   ##
===========================================
+ Coverage    0.05%   20.89%   +20.83%     
===========================================
  Files         117     1554     +1437     
  Lines        3425    36074    +32649     
  Branches      893     7064     +6171     
===========================================
+ Hits            2     7538     +7536     
- Misses       3423    27795    +24372     
- Partials        0      741      +741

Files Changed	Coverage Δ
...p2p/src/components/order-details/order-details.jsx	`0.00% <0.00%> (ø)`
...ges/p2p/src/components/orders/chat/chat-footer.jsx	`0.00% <ø> (ø)`
...p/src/components/orders/chat/chat-message-text.jsx	`0.00% <0.00%> (ø)`
...s/p2p/src/components/orders/chat/chat-messages.jsx	`0.00% <0.00%> (ø)`
packages/p2p/src/stores/sendbird-store.js	`0.00% <0.00%> (ø)`
packages/p2p/src/utils/chat-message.js	`36.84% <60.00%> (ø)`

... and 1587 files with indirect coverage changes

packages/p2p/src/utils/chat-message.js

niloofar-deriv

LGTM 👍

sonarcloud · 2023-05-01T13:06:00Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
7.0% Duplication

github-actions · 2023-07-03T00:25:09Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

gitguardian · 2023-07-03T06:13:38Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`e2d2b25`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`e2d2b25`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

coveralls · 2023-07-11T07:25:07Z

coverage: 9.644%. remained the same when pulling 9591977 on nada-deriv:nada/P2PS-491/chatbox-message into a69c685 on binary-com:master.

github-actions · 2023-07-18T08:10:09Z

⏳ Generating Lighthouse report...

sonarcloud · 2023-08-09T08:07:33Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonarcloud · 2023-09-14T07:08:31Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
53.7% Duplication

DerivFE · 2023-09-18T08:51:32Z

✨ PR has been merged by Paimon the Release Bot

feat: chat box message after order creation

8d3cba6

boring-cyborg bot added the P2P label May 1, 2023

vercel bot deployed to Preview May 1, 2023 06:08 View deployment

farrah-deriv reviewed May 1, 2023

View reviewed changes

packages/p2p/src/utils/chat-message.js Outdated Show resolved Hide resolved

feat: removed chat footer from chat section

58ed564

vercel bot deployed to Preview May 1, 2023 10:12 View deployment

niloofar-deriv reviewed May 1, 2023

View reviewed changes

packages/p2p/src/utils/chat-message.js Outdated Show resolved Hide resolved

niloofar-deriv approved these changes May 1, 2023

View reviewed changes

fix: updated with latest master

c93b1c0

vercel bot deployed to Preview May 1, 2023 13:14 View deployment

farhan-nurzi-deriv approved these changes May 2, 2023

View reviewed changes

farrah-deriv previously approved these changes May 3, 2023

View reviewed changes

github-actions bot added the Stale label Jul 3, 2023

Merge branch 'master' into nada/P2PS-491/chatbox-message

e2d2b25

farrah-deriv removed the Stale label Jul 3, 2023

vercel bot deployed to Preview July 3, 2023 07:16 View deployment

Merge branch 'master' into nada/P2PS-491/chatbox-message

2f2c7ac

vercel bot deployed to Preview July 3, 2023 10:16 View deployment

Merge branch 'master' into nada/P2PS-491/chatbox-message

7df0c5f

vercel bot deployed to Preview July 11, 2023 07:20 View deployment

Merge branch 'master' into nada/P2PS-491/chatbox-message

a50eb0f

vercel bot deployed to Preview July 18, 2023 08:23 View deployment

feat: merge conflicts resolved

80d4aa0

nada-deriv dismissed farrah-deriv’s stale review via 80d4aa0 August 1, 2023 11:28

vercel bot deployed to Preview August 1, 2023 11:41 View deployment

feat: fixed issue with admin message not shown

9591977

vercel bot deployed to Preview August 2, 2023 05:32 View deployment

feat: updated with latest master

892ae3c

nada-deriv requested a review from nijil-deriv as a code owner August 7, 2023 05:40

vercel bot deployed to Preview August 7, 2023 06:01 View deployment

chore: add unit test for chatbot message

7681c76

vercel bot deployed to Preview August 9, 2023 08:45 View deployment

ameerul-deriv approved these changes Aug 11, 2023

View reviewed changes

farhan-nurzi-deriv approved these changes Aug 11, 2023

View reviewed changes

farrah-deriv previously approved these changes Aug 15, 2023

View reviewed changes

fix: fix conflicts with master

ac1cd05

nada-deriv dismissed farrah-deriv’s stale review via ac1cd05 September 14, 2023 07:03

ameerul-deriv approved these changes Sep 14, 2023

View reviewed changes

vercel bot deployed to Preview September 14, 2023 07:41 View deployment

farrah-deriv approved these changes Sep 14, 2023

View reviewed changes

DerivFE merged commit 4662737 into binary-com:master Sep 18, 2023
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: chat box message after order creation #8405

feat: chat box message after order creation #8405

nada-deriv commented May 1, 2023

vercel bot commented May 1, 2023 •

edited

Loading

github-actions bot commented May 1, 2023 •

edited

Loading

github-actions bot commented May 1, 2023 •

edited

Loading

codecov-commenter commented May 1, 2023 •

edited by codecov bot

Loading

niloofar-deriv left a comment

sonarcloud bot commented May 1, 2023

github-actions bot commented Jul 3, 2023

gitguardian bot commented Jul 3, 2023 •

edited

Loading

coveralls commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 18, 2023 •

edited

Loading

sonarcloud bot commented Aug 9, 2023

sonarcloud bot commented Sep 14, 2023

DerivFE commented Sep 18, 2023

feat: chat box message after order creation #8405

feat: chat box message after order creation #8405

Conversation

nada-deriv commented May 1, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented May 1, 2023 • edited Loading

github-actions bot commented May 1, 2023 • edited Loading

github-actions bot commented May 1, 2023 • edited Loading

codecov-commenter commented May 1, 2023 • edited by codecov bot Loading

Codecov Report

niloofar-deriv left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 1, 2023

github-actions bot commented Jul 3, 2023

gitguardian bot commented Jul 3, 2023 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

coveralls commented Jul 11, 2023 • edited Loading

github-actions bot commented Jul 18, 2023 • edited Loading

sonarcloud bot commented Aug 9, 2023

sonarcloud bot commented Sep 14, 2023

DerivFE commented Sep 18, 2023

vercel bot commented May 1, 2023 •

edited

Loading

github-actions bot commented May 1, 2023 •

edited

Loading

github-actions bot commented May 1, 2023 •

edited

Loading

codecov-commenter commented May 1, 2023 •

edited by codecov bot

Loading

gitguardian bot commented Jul 3, 2023 •

edited

Loading

coveralls commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 18, 2023 •

edited

Loading