Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameerul | Niloofar | Add routing for all P2P pages #8623

Merged

Conversation

niloofar-deriv
Copy link
Contributor

@niloofar-deriv niloofar-deriv commented May 16, 2023

Changes:

We have 4 main tabs under the Deriv P2P website which consist of Buy/Sell, Orders, My Ads, and My Profile. Each of these tabs does not have an endpoint. As of now, we only have one endpoint URL for Deriv P2P which would be https://app.deriv.com/cashier/p2p. Hence, we would want to have a separate endpoint for all 4 tabs under Deriv P2P.

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 11:08am

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8623](https://github.com/binary-com/deriv-app/pull/8623)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloofar-deriv-feq-124-add-p2p-routing.binary.sx?qa_server=red.binaryws.com&app_id=32466
    - **Original**: https://deriv-app-git-fork-niloofar-deriv-feq-124-add-p2p-routing.binary.sx
- **App ID**: `32466`

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-niloofar-deriv-feq-124-add-p2p-routing.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #8623 (e8a7fb0) into master (d5c38a0) will not change coverage.
The diff coverage is 0.00%.

❗ Current head e8a7fb0 differs from pull request most recent head 52a08f1. Consider uploading reports for the commit 52a08f1 to get more accurate results

@@          Coverage Diff           @@
##           master   #8623   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3425           
  Branches      893     893           
======================================
  Hits            2       2           
  Misses       3423    3423           
Impacted Files Coverage Δ
packages/cashier/src/constants/routes-config.ts 0.00% <0.00%> (ø)

@boring-cyborg boring-cyborg bot added the Docs label May 18, 2023
farzin-deriv
farzin-deriv previously approved these changes May 18, 2023
@coveralls
Copy link

coveralls commented Jul 3, 2023

Coverage Status

coverage: 8.846% (-0.03%) from 8.875% when pulling ed7e688 on niloofar-deriv:FEQ-124/add-p2p-routing into f48ed0d on binary-com:master.

@ali-hosseini-deriv
Copy link
Member

👌 Pull request has been updated with the base branch by Paimon the Release Bot

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit 5df7ec6 into binary-com:master Jul 5, 2023
5 of 6 checks passed
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

jim-deriv added a commit to jim-deriv/deriv-app that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet